JP-3667: Add safeguards for NSClean on background/imprint members

[melanieclarke]

Resolves JP-3667

Follow up to #8786 to fix some unexpected interactions between badpix_selfcal and nsclean, causing a failure in the badpix_selfcal regression tests. If badpix_selfcal is run, the background members are datamodels instead of filenames.

I also noticed in testing this that setting the output file for nsclean on the background/imprint members caused them to be saved by default, so I added a check for that as well.

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
• Does this PR change user-facing code / API?
  • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[melanieclarke]

Regtests here:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1735/

[emolter]

LGTM pending regression tests showing no unexpected failures

[codecov]

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.78%. Comparing base (9c68fc3) to head (dc2ce65).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
jwst/pipeline/calwebb_spec2.py	6.25%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8809      +/-   ##
==========================================
+ Coverage   61.76%   61.78%   +0.02%     
==========================================
  Files         377      377              
  Lines       38785    38836      +51     
==========================================
+ Hits        23955    23996      +41     
- Misses      14830    14840      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hayescr]

LGTM as well, sorry I missed this on the last one.

[melanieclarke]

LGTM as well, sorry I missed this on the last one.

My fault, trying to do too many things too fast! Thanks for reviewing.

[melanieclarke]

Regression tests look good. I will merge when CI is complete.