Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3305: New association candidate type to group mosaic tiles across targets #8798

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented Sep 17, 2024

Resolves JP-3305

Closes #7725

This PR addresses a failure to generate associations for MOSAIC association candidates, due to our level 3 imaging candidates requiring a match on target id. This PR introduces a MOSAIC-candidate-specific class that relaxes the target id constraint, utilizing the filler t000 identifier introduced by #8528.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@tapastro tapastro added this to the Build 11.1 milestone Sep 17, 2024
@tapastro tapastro requested a review from a team as a code owner September 17, 2024 19:55
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.77%. Comparing base (da9691d) to head (7a7f4a4).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8798      +/-   ##
==========================================
+ Coverage   61.75%   61.77%   +0.02%     
==========================================
  Files         377      377              
  Lines       38750    38777      +27     
==========================================
+ Hits        23931    23956      +25     
- Misses      14819    14821       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tapastro
Copy link
Contributor Author

Regtest run on associations tests ran here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1725/

I okify'ed prematurely, only to get the files into the truth directory. The value/correctness of the association file will have to be determined independent of a test result here, but the associations utilizing the new rule show t000 in the product name, indicating multiple targets are present. They also contain all members matching the optical path, but across all observations linked with the c1000 candidate tag.

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from a code and documentation perspective.

@tapastro
Copy link
Contributor Author

Started a test run against only sdp_pools here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1732/

@tapastro tapastro merged commit d84ce8e into spacetelescope:master Sep 19, 2024
8 of 9 checks passed
@tapastro tapastro deleted the jp-3305-mosaic-asns branch September 19, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOSAIC association candidate id redundant, includes only single observation
3 participants