Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3695: Clean up unnecessary copies #8676

Merged
merged 104 commits into from
Sep 20, 2024
Merged

JP-3695: Clean up unnecessary copies #8676

merged 104 commits into from
Sep 20, 2024

Commits on Jun 21, 2024

  1. running time and memory usage substantial improvement

    @penaguerrero
    penaguerrero committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    994e729 View commit details
    Browse the repository at this point in the history

  2. added description of PR

    @penaguerrero
    penaguerrero committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a1c088b View commit details
    Browse the repository at this point in the history

  3. updated docs

    @penaguerrero
    penaguerrero committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    048414b View commit details
    Browse the repository at this point in the history

  4. removed unused code

    @penaguerrero
    penaguerrero committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d53d1fa View commit details
    Browse the repository at this point in the history

  5. addressing comments in PR

    @penaguerrero
    penaguerrero committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1bf6096 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0828bc3 View commit details
    Browse the repository at this point in the history

  7. adding a missing comma

    @penaguerrero
    penaguerrero committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c59656b View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2c899be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    db29e55 View commit details
    Browse the repository at this point in the history

  3. removing copies and adding optional model class as input

    @penaguerrero
    penaguerrero committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    083705c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3266e39 View commit details
    Browse the repository at this point in the history

  5. silly mistake

    @penaguerrero
    penaguerrero committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0b16f54 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c3a6084 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    84ea302 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3a3ccf2 View commit details
    Browse the repository at this point in the history

  4. returning some code to prevent input to be modified in-place

    @penaguerrero
    penaguerrero committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5b42065 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fdefa18 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4b5bee7 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6922f4b View commit details
    Browse the repository at this point in the history

  2. added step class attribute to avoid pile up of memory

    @penaguerrero
    penaguerrero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c1ed7c0 View commit details
    Browse the repository at this point in the history

  3. removed print statement

    @penaguerrero
    penaguerrero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c0a4a12 View commit details
    Browse the repository at this point in the history

  4. fixed silly bug

    @penaguerrero
    penaguerrero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    bc37ddb View commit details
    Browse the repository at this point in the history

  5. removed unused code

    @penaguerrero
    penaguerrero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    87c6bd6 View commit details
    Browse the repository at this point in the history

  6. removed unused code

    @penaguerrero
    penaguerrero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8cc1a01 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b404403 View commit details
    Browse the repository at this point in the history

  8. rename of variable

    @penaguerrero
    penaguerrero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3617d47 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. removed Step attribute modify_input

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    17dfc33 View commit details
    Browse the repository at this point in the history

  2. removed the close statement

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3905694 View commit details
    Browse the repository at this point in the history

  3. removed the close statement

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3d19630 View commit details
    Browse the repository at this point in the history

  4. fixing tests

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0f1549c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1bdc7de View commit details
    Browse the repository at this point in the history

  6. fixing tests

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c65cbee View commit details
    Browse the repository at this point in the history

  7. removed the copy since this is now handled in ipc_step.py

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2f41a6a View commit details
    Browse the repository at this point in the history

  8. run test on copy of datamodel

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0209356 View commit details
    Browse the repository at this point in the history

  9. fixed silly mistake

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5633f90 View commit details
    Browse the repository at this point in the history

  10. now returning an open model

    @penaguerrero
    penaguerrero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    43deb58 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. removing with statement to open datamodel

    @penaguerrero
    penaguerrero committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    11c24df View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1f6a54a View commit details
    Browse the repository at this point in the history

  2. moved change to unreleased notes

    @penaguerrero
    penaguerrero committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    54083e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4223b90 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4425d81 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3956bd4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    dedc920 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    344f5dd View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    4c9aada View commit details
    Browse the repository at this point in the history

  2. addressing PR comments

    @penaguerrero
    penaguerrero committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    111ee46 View commit details
    Browse the repository at this point in the history

  3. fixing emicorr test

    @penaguerrero
    penaguerrero committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c2a8f1d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f484e0f View commit details
    Browse the repository at this point in the history

  5. fixing tests

    @penaguerrero
    penaguerrero committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    372a8e3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    82e6b9d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f739847 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a3386fd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f40ddbe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f75e8e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5f8f7c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'master' into speedupemicorr

    @penaguerrero
    penaguerrero authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    22c3721 View commit details
    Browse the repository at this point in the history

  2. removing unnecessary copies

    @penaguerrero
    penaguerrero committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ef4e80a View commit details
    Browse the repository at this point in the history

  3. removing PR number as this does not change functionallity for user

    @penaguerrero
    penaguerrero committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7578b1a View commit details
    Browse the repository at this point in the history

  4. removing unused import

    @penaguerrero
    penaguerrero committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    13cac74 View commit details
    Browse the repository at this point in the history

  5. making sure both types are float

    @penaguerrero
    penaguerrero committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    22c04ec View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4ac5cf6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    5028b42 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1d85ae0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    669bd12 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    38eee30 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    beb7778 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8ac51d4 View commit details
    Browse the repository at this point in the history

  2. cleaning up emicorr a bit further

    @penaguerrero
    penaguerrero committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d23ca59 View commit details
    Browse the repository at this point in the history

  3. clean up not needed array initialization

    @penaguerrero
    penaguerrero committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    950f640 View commit details
    Browse the repository at this point in the history

  4. furthere clean up

    @penaguerrero
    penaguerrero committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6a718ec View commit details
    Browse the repository at this point in the history

  5. fixing test correponding with the changes

    @penaguerrero
    penaguerrero committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    59339d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6f34262 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6f6a04c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9e55740 View commit details
    Browse the repository at this point in the history

  2. fixing emicorr tests

    @penaguerrero
    penaguerrero committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    73005c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c22036b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8a00dec View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8d33e02 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0658608 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a41e0e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. adding reg test for memory usage on detector1

    @penaguerrero
    penaguerrero committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0ffe3f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7bcf76e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b8713e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9ec1cec View commit details
    Browse the repository at this point in the history

  2. switching mprof for tracemalloc

    @penaguerrero
    penaguerrero committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    27242cf View commit details
    Browse the repository at this point in the history

  3. minor changes

    @penaguerrero
    penaguerrero committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e924fe9 View commit details
    Browse the repository at this point in the history

  4. fixing bug

    @penaguerrero
    penaguerrero committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a1119f1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    13dad07 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2c22441 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a95a87a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2ba56f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0af659a View commit details
    Browse the repository at this point in the history

  2. fixing bug after rebase

    @penaguerrero
    penaguerrero committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    332cdd7 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    aa3415b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    84c024d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ac2d02f View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4858aad View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7c63461 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'master' into copy_cleanup_det1

    @tapastro
    tapastro authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5462db4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ac45411 View commit details
    Browse the repository at this point in the history

  3. addressing PR comments

    @penaguerrero
    penaguerrero committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    823e50c View commit details
    Browse the repository at this point in the history

  4. adding PR changes

    @penaguerrero
    penaguerrero committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    26eaa9c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into copy_cleanup_det1

    @penaguerrero
    penaguerrero authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    82d7494 View commit details
    Browse the repository at this point in the history

  6. Update emicorr docs

    @tapastro
    tapastro authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a4741e8 View commit details
    Browse the repository at this point in the history