Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2546: updates and fixes for wfss_contam step #8417

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Apr 10, 2024

Resolves JP-2546

Closes #7288

This PR addresses several of the remaining tasks needed to make the wfss_contam step fully functional. Submitting a draft now so everyone can see the proposed changes, although there are still several outstanding issues. See the JIRA ticket for many more details.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 79.92278% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 75.72%. Comparing base (6580914) to head (632fdec).
Report is 4 commits behind head on master.

❗ Current head 632fdec differs from pull request most recent head 5efdbb6. Consider uploading reports for the commit 5efdbb6 to get more accurate results

Files Patch % Lines
jwst/wfss_contam/wfss_contam.py 68.46% 41 Missing ⚠️
jwst/wfss_contam/observations.py 91.57% 8 Missing ⚠️
jwst/wfss_contam/wfss_contam_step.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8417       +/-   ##
===========================================
+ Coverage   56.38%   75.72%   +19.34%     
===========================================
  Files         387      476       +89     
  Lines       38716    39661      +945     
===========================================
+ Hits        21830    30035     +8205     
+ Misses      16886     9626     -7260     
Flag Coverage Δ *Carryforward flag
nightly 77.74% <ø> (?) Carriedforward from 1859827

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates and fixes for WFSS contamination correction
1 participant