JP-3151: Don't make associations for NRS2 IFU if detector not illumin…

…ated (#8395)

Co-authored-by: Howard Bushouse <[email protected]>

CHANGES.rst

@@ -1,6 +1,12 @@
 1.14.1 (unreleased)
 ===================
 
+associations
+------------
+
+- Ensure NRS IFU exposures don't make a spec2 association for grating/filter combinations 
+  where the nrs2 detector isn't illuminated.  Remove dupes in mkpool. [#8395]
+
 documentation
 -------------
 

jwst/associations/lib/rules_level2b.py

@@ -320,7 +320,12 @@ def __init__(self, *args, **kwargs):
                     )
                 ],
                 reduce=Constraint.notany
-            )
+            ),
+            SimpleConstraint(
+                value=True,
+                test=lambda value, item: nrsifu_valid_detector(item),
+                force_unique=False
+            ),
         ])
 
         # Now check and continue initialization.

jwst/associations/mkpool.py

@@ -106,9 +106,10 @@ def mkpool(data,
 
     params = params.difference(IGNORE_KEYS)
     params = [item.lower() for item in params]
+    # Make sure there's no duplicates
+    params = list(set(params))
     params.sort()
     defaults = {param: 'null' for param in params}
-
     pool = AssociationPool(names=params, dtype=[object] * len(params))
 
     # Set default values for user-settable non-header parameters

jwst/associations/tests/test_exposerr.py

@@ -21,7 +21,7 @@ def test_exposerr():
         pool=pool
     )
     asns = generated.associations
-    assert len(asns) > 1
+    assert len(asns) == 1
     for asn in asns:
         any_degraded = False
         for product in asn['products']: