Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: source_id is lowercase in Gaia output (sometimes) #3400

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 21, 2025

Description

Alternative to #3395

Since we only see in test and no one reported bug yet (outside of workshop), probably no need change log.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive backport-v4.1.x on-merge: backport to v4.1.x labels Jan 21, 2025
@pllim pllim added this to the 4.1.1 milestone Jan 21, 2025
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Jan 21, 2025
@pllim
Copy link
Contributor Author

pllim commented Jan 21, 2025

devdeps failure unrelated

@pllim pllim modified the milestone: 4.1.1 Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.62%. Comparing base (87016c7) to head (783a791).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/configs/imviz/plugins/catalogs/catalogs.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3400   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         128      128           
  Lines       19843    19844    +1     
=======================================
+ Hits        17387    17388    +1     
  Misses       2456     2456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry
Copy link
Member

kecnry commented Jan 21, 2025

is this only isolated to CI or could users run into this (in which case maybe we want a changelog entry)?

@pllim
Copy link
Contributor Author

pllim commented Jan 21, 2025

could users run into this

@cshanahan1 how many were actually affected at the workshop? Are they all using the same OS or you see any pattern?

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we get this in so other tests stop getting cancelled?

@kecnry
Copy link
Member

kecnry commented Jan 21, 2025

agreed - I'd vote for a small changelog just in case anyone runs into this then they know which release they need to get the fix, but it'll be nice to have all the test failures cleared 🤞

@pllim pllim removed the no-changelog-entry-needed changelog bot directive label Jan 21, 2025
@pllim
Copy link
Contributor Author

pllim commented Jan 21, 2025

OK added. Thanks for the reviews!

@pllim pllim enabled auto-merge (squash) January 21, 2025 23:29
@pllim pllim mentioned this pull request Jan 21, 2025
9 tasks
@pllim pllim merged commit ed09c31 into spacetelescope:main Jan 22, 2025
20 of 22 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 22, 2025
@pllim pllim deleted the fix-cat-ci-meow branch January 22, 2025 03:23
pllim added a commit that referenced this pull request Jan 22, 2025
…0-on-v4.1.x

Backport PR #3400 on branch v4.1.x (BUG: source_id is lowercase in Gaia output (sometimes))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x bug Something isn't working imviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants