-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: source_id is lowercase in Gaia output (sometimes) #3400
Conversation
devdeps failure unrelated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3400 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 128 128
Lines 19843 19844 +1
=======================================
+ Hits 17387 17388 +1
Misses 2456 2456 ☔ View full report in Codecov by Sentry. |
is this only isolated to CI or could users run into this (in which case maybe we want a changelog entry)? |
@cshanahan1 how many were actually affected at the workshop? Are they all using the same OS or you see any pattern? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we get this in so other tests stop getting cancelled?
agreed - I'd vote for a small changelog just in case anyone runs into this then they know which release they need to get the fix, but it'll be nice to have all the test failures cleared 🤞 |
OK added. Thanks for the reviews! |
…output (sometimes)
…0-on-v4.1.x Backport PR #3400 on branch v4.1.x (BUG: source_id is lowercase in Gaia output (sometimes))
Description
Alternative to #3395
Since we only see in test and no one reported bug yet (outside of workshop), probably no need change log.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.