Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonification plugin tweaks #3377
base: main
Are you sure you want to change the base?
Sonification plugin tweaks #3377
Changes from 13 commits
7f84c6c
c09b879
bccd33a
2f334a5
31ded3b
e77c182
b514570
ef7436f
89b76ee
eae4323
f49785e
6922dfe
ff220be
a58e221
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 48 in jdaviz/configs/cubeviz/plugins/cube_listener.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/cube_listener.py#L48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we mixing number and string in this tuple?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is
strauss
syntax where strings are used for percentiles while numeric represents absolute values. In this case the maximum of the spectrum is the 100th %ile (i.e. max) in flux but using 0 flux for the minimum, rather than the 0th %ile in flux (min). I'll add a comment to clarify thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is kinda confusing. Why not be more explicit in the string specs like
'100%'
or'100pct'
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that could be an improvement - I will add accepting
'XX%'
as a percentile format in the next batch of strauss changes - though would this be ok for now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the limitation, sure. The comment is helpful enough for now. Thanks!
Check warning on line 98 in jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py#L98
Check warning on line 101 in jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py#L101
Check warning on line 120 in jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py#L120
Check warning on line 123 in jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py#L122-L123
Check warning on line 126 in jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/sonify_data/sonify_data.py#L125-L126
Check warning on line 118 in jdaviz/configs/cubeviz/plugins/viewers.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/viewers.py#L118
Check warning on line 146 in jdaviz/configs/cubeviz/plugins/viewers.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/viewers.py#L144-L146
Check warning on line 148 in jdaviz/configs/cubeviz/plugins/viewers.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/viewers.py#L148
Check warning on line 162 in jdaviz/configs/cubeviz/plugins/viewers.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/viewers.py#L162
Check warning on line 164 in jdaviz/configs/cubeviz/plugins/viewers.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/viewers.py#L164
Check warning on line 167 in jdaviz/configs/cubeviz/plugins/viewers.py
Codecov / codecov/patch
jdaviz/configs/cubeviz/plugins/viewers.py#L167