Fix logic flow in _parse_hdulist for Cubeviz #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for Cubeviz
pllim
added
bug
pllim
requested review from
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
github-actions
bot
added
cubeviz
plugin
pllim
commented
May 1, 2024
| @@ -257,15 +257,13 @@ def _parse_hdulist(app, hdulist, file_name=None, | |||
| if hdu.name != 'PRIMARY' and 'PRIMARY' in hdulist: | |||
| metadata[PRIHDR_KEY] = standardize_metadata(hdulist['PRIMARY'].header) | |||
|
|
|||
| sc = _return_spectrum_with_correct_units(flux, wcs, metadata, data_type, hdulist=hdulist) | |||
|
|
|||
| # store original WCS in metadata. this is a hacky workaround for converting subsets | |||
| # to sky regions, where the parent data of the subset might have dropped spatial WCS info | |||
| metadata['_orig_spatial_wcs'] = _get_celestial_wcs(wcs) | |||
There was a problem hiding this comment.
This was added in #2496 by @cshanahan1 . I think the metadata change here was a bit too late; should have been done before being passed into sc.
pllim
commented
May 1, 2024
| app.add_data(sc, data_label) | ||
| if data_type == 'flux': # Forced wave unit conversion made it lose stuff, so re-add |
There was a problem hiding this comment.
This one was blamed to me back in #1480 but I have no recollection writing it... It was @javerbukh's PR so maybe he remembers why we did it this way or whether we can move it further down. 🤷♀️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
+ Coverage 88.94% 88.95% +0.01%
==========================================
Files 111 111
Lines 17101 17101
==========================================
+ Hits 15211 15213 +2
+ Misses 1890 1888 -2 ☔ View full report in Codecov by Sentry. |
kecnry
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed these while investigating something else. Technically a bug but it is buried so deeply in the internals I don't think users would notice, so probably don't need a change log.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.