Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Omit specreduce dev from devdeps #1881

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 30, 2022

Description

This pull request is to omit dev version of specreduce from devdeps because that package is undergoing a lot of API changes.

Close #1877

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.1.x on-merge: backport to v3.1.x labels Nov 30, 2022
@pllim pllim added this to the 3.1.2 milestone Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 88.37% // Head: 88.37% // No change to project coverage 👍

Coverage data is based on head (55090c0) compared to base (0b76ee4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1881   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          95       95           
  Lines       10456    10456           
=======================================
  Hits         9241     9241           
  Misses       1215     1215           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rosteen
Copy link
Collaborator

rosteen commented Nov 30, 2022

@kecnry @ojustino I'll leave it to one of you to approve this, in case you object.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the best/only way to go until specreduce is stable enough that we can remove the exact minor-version pin.

Maybe we should also add a comment in setup.cfg to remind us to add this back when we do loosen up the version there?

@ojustino
Copy link
Contributor

No objections from me, though I do support adding a reminder for the future in setup.cfg.

@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2022

I added it back to tox.ini but commented out with a comment. Is that good enough?

@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2022

Tsk tsk CI didn't kick off

@pllim pllim closed this Nov 30, 2022
@pllim pllim reopened this Nov 30, 2022
@ojustino
Copy link
Contributor

You have the requisite approval already, but I still think a reminder couldn't hurt for the sake of whomever ends up changing this in the future.

@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2022

I still think a reminder couldn't hurt

I agree but I guess I just think the reminder being in tox.ini is closer to where it should be done.

@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2022

Should I also open a follow-up issue?

Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support creating a follow-up issue; that fits with standard procedure here.

@pllim pllim merged commit e62105b into spacetelescope:main Nov 30, 2022
@pllim pllim deleted the fix-devdeps-spec2d branch November 30, 2022 20:34
@pllim
Copy link
Contributor Author

pllim commented Nov 30, 2022

Thanks for the reviews! Follow-up issue created in #1883

pllim added a commit that referenced this pull request Nov 30, 2022
…1-on-v3.1.x

Backport PR #1881 on branch v3.1.x (TST: Omit specreduce dev from devdeps)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Fix failing tests in devdeps job
4 participants