-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Omit specreduce dev from devdeps #1881
Conversation
Codecov ReportBase: 88.37% // Head: 88.37% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 95 95
Lines 10456 10456
=======================================
Hits 9241 9241
Misses 1215 1215 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the best/only way to go until specreduce is stable enough that we can remove the exact minor-version pin.
Maybe we should also add a comment in setup.cfg
to remind us to add this back when we do loosen up the version there?
No objections from me, though I do support adding a reminder for the future in |
I added it back to |
Tsk tsk CI didn't kick off |
You have the requisite approval already, but I still think a reminder couldn't hurt for the sake of whomever ends up changing this in the future. |
I agree but I guess I just think the reminder being in |
Should I also open a follow-up issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support creating a follow-up issue; that fits with standard procedure here.
Thanks for the reviews! Follow-up issue created in #1883 |
…1-on-v3.1.x Backport PR #1881 on branch v3.1.x (TST: Omit specreduce dev from devdeps)
Description
This pull request is to omit dev version of specreduce from devdeps because that package is undergoing a lot of API changes.
Close #1877
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.