Make DM map and command functions to outside of ServiceProxy. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivalaginja
reviewed
Oct 25, 2024
| command_length = np.sum(device_actuator_mask) | ||
|
|
||
| # If we're given a DM map, convert it to a command. | ||
| if dm_shape.shape != (command_length,): |
There was a problem hiding this comment.
Is the comma here on purpose?
There was a problem hiding this comment.
Yes, it's a comparison with a tuple. No new code, it was just moved from inside to outside the class.
ivalaginja
approved these changes
Oct 25, 2024
This allows us to operate on DM commands without spinning up an entire simulator.
ehpor
force-pushed
the
feature/dm_map_command_functions
branch
from
ca71309 to
5d21fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to operate on DM commands without spinning up an entire simulator.