use tmp_path in unit tests to fix concurrent file access / deletion
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it should be functionally identical however (tests pass now) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 87.64% 83.90% -3.75%
==========================================
Files 17 17
Lines 1392 1323 -69
==========================================
- Hits 1220 1110 -110
- Misses 172 213 +41 ☔ View full report in Codecov by Sentry. |
zacharyburnett
force-pushed
the
fix/concurrency_files
branch
6 times, most recently
from
c4d97e7
to
b5042f6
Compare
zacharyburnett
force-pushed
the
fix/concurrency_files
branch
from
b5042f6
to
1146670
Compare
zacharyburnett
force-pushed
the
fix/concurrency_files
branch
from
1146670
to
4908465
Compare
zacharyburnett
added a commit
to zacharyburnett/calcos
that referenced
this pull request
Aug 21, 2024
zacharyburnett
added a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that tests can be run concurrently without stepping on each others' toes