Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert numpy2 testing commit so we can release #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stscirij
Copy link
Contributor

@stscirij stscirij commented Jun 7, 2024

No description provided.

@stscirij stscirij requested a review from a team as a code owner June 7, 2024 13:34
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.41%. Comparing base (8eb63d1) to head (85bfef1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   87.64%   87.41%   -0.23%     
==========================================
  Files          17       17              
  Lines        1392     1367      -25     
==========================================
- Hits         1220     1195      -25     
  Misses        172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI, this will work for the next few weeks, but when Numpy 2 is released on the 19th, any users who try to run calcos with numpy>=2.0.0 installed will get a runtime error that looks like this:

A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.1.0.dev0 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

https://github.com/spacetelescope/calcos/actions/runs/9417921200/job/25944177737?pr=240#step:10:205

Since all the tests appear to run fine when the calcos wheel is built with Numpy 2 (see the most recent CI run on master), from what I can see there is no harm in keeping this set to numpy>=2.0.0rc2 until the release, after which we can update it to numpy>=2.0.0 if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants