replace interp2d in utils_findsat_mrt #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces the old interpolation method in acstools.utils_findsat_mrt.create_mrt_line_kernel from scipy.interpolate.interp2d to scipy.interpolate.RegularGridInterpolator. This request was made by Alyssa Guzman on behalf of DMD because interp2d has been deprecated and they want all packages to be compatible with the latest versions of 3rd party packages. For this update, I used scipy 1.14.1. I have tested the new interpolation method and it returns the same output as the prior method, with some slight variations, but these are very small and acceptable.