Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ADS link to CITATION.md #204

Merged
merged 4 commits into from
Apr 15, 2024
Merged

added ADS link to CITATION.md #204

merged 4 commits into from
Apr 15, 2024

Conversation

gsanand
Copy link
Contributor

@gsanand gsanand commented Apr 15, 2024

No description provided.

@gsanand gsanand requested a review from dvstark April 15, 2024 15:00
@github-actions github-actions bot added the docs label Apr 15, 2024
CITATION.md Outdated
@@ -5,3 +5,5 @@ If you use acstools, please cite as:
#### Other forms of citation

[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.7406933.svg)](https://doi.org/10.5281/zenodo.7406933)

[![NASA/ADS-ACStools](https://img.shields.io/badge/NASA%2FADS-ACStools-blue)](https://ui.adsabs.harvard.edu/abs/2020ascl.soft11024L/abstract)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you want to move this to primary citation section to be consistent with RTD, and move the ASCL one down here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that makes sense. just changed!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pllim Does this all look standard now? I think you know more about that than me :)

Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@pllim pllim merged commit a4e3664 into spacetelescope:master Apr 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants