Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STIPS 2.2 Pull Request #175

Merged
merged 15 commits into from
May 10, 2024
Merged

STIPS 2.2 Pull Request #175

merged 15 commits into from
May 10, 2024

Conversation

gmzsebastian
Copy link
Collaborator

This pull requests includes a number of bug fixed and improvements to STIPS for its 2.2 release, including:

  • Updated the requirements to Pandeia 3.1
  • Updated the Pandeia reference data.
  • Fixed two bugs with extended sources, one with the orientation of the WCS, and another that was causing all galaxies to be generated with sersic index n = 1.
  • Included a feature where users can add a boolean flag "fast_galaxy" to use an older, faster, less accurate, method for injecting extending sources.
  • Updated the documentation to reflect the new "fast_galaxy" capability.

@gmzsebastian gmzsebastian requested a review from ojustino May 1, 2024 14:53
@ojustino
Copy link
Collaborator

ojustino commented May 9, 2024

Hello @gmzsebastian, thank you for your work in this PR. I've addressed most of the findings of my code review in gmzsebastian#6, so please check it out. Other than that, I have a few questions:

  • Could you please update CHANGES.rst here with entries for 2.2.0? These should include the upgraded minimum versions of Pandeia (and Python, if you accept Release 2.2 edits gmzsebastian/STScI-STIPS#6).
  • Do we still need to specify that webbpsf==1.1.0 exactly or is it possible to work with any of the newer versions? RSP would probably appreciate the flexibility in the latter case, but I don't think it should delay the v2.2.0 release if not.
  • What do you think of switching the repository's primary feature branch from master to main to bring it in line with other repositories in the ST/astropy universe? I don't think that action is technically linked to the release, so I can do it after the release is over if you agree.

@ojustino
Copy link
Collaborator

ojustino commented May 9, 2024

Thanks for merging my pull request. What do you think about the questions in my last comment here? (And about the possibility of listing a number for how much less accurate the fast_galaxy scenario is in the examples.rst?) I believe we're ready for a merge once those have been addressed.

@ojustino ojustino merged commit 3170285 into spacetelescope:master May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants