Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword to indicate a movie was added, not "watched" #108

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Reword to indicate a movie was added, not "watched" #108

merged 1 commit into from
Jul 16, 2019

Conversation

wtimme
Copy link
Contributor

@wtimme wtimme commented Jul 15, 2019 •
edited
Loading

I've changed the string onDate to "Added on" in English/Base and "Hinzugefügt am" in German.

Fixes #105.

@wtimme
#105 Reword to indicate a movie was added, not "watched"
4121bf2 
"Seen" implies that the user has "watched" the movie at the
date and time, when instead they only _added_ it to the app.
fbernutz
fbernutz approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@fbernutz fbernutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I "love" how easy the review for this is in GitHub.... But I tested it in Xcode and it looks good! Thanks!

@fbernutz fbernutz merged commit c32b3a0 into spacepandas:master Jul 16, 2019
@wtimme wtimme deleted the feature/105-Change-wording-of-history-cell-subtitle branch July 16, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbernutz fbernutz fbernutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rethink "Seen on [date]" in list of seen movies
2 participants
@wtimme @fbernutz