Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fullscreen button #134

Open
wants to merge 1 commit into
base: mnt
Choose a base branch
from
Open

Conversation

banglashi
Copy link
Collaborator

No description provided.

@mntmn
Copy link
Member

mntmn commented Nov 21, 2020

Can you explain the use case vs using the browser's built-in button / key (F11)? Is this for embedded spaces?

@mntmn
Copy link
Member

mntmn commented Nov 21, 2020

See #104 (comment)

@banglashi
Copy link
Collaborator Author

Hi @mntmn,
I like the idea of adding it to a "View" dropdown. The use case is the same as the browser's built-in button / key (F11) but I think a lot of "normal" users are not aware of this.

@plomlompom
Copy link
Collaborator

I assume a fullscreen option mostly benefits users with smaller screen estate, so they can make maximum use of the little they have. But in such a context, the low placement of the fullscreen button defeats its purpose (as I just tested on my common screen resolution of 768 lines): For non-fullscreen views, it stretches the button sequence beyond the lower margin of the screen, with the very button to get into fullscreen mode easily sliding out of visibility. Not sure what the elegant solution to that would be though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants