Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy Request (opcode 14) ordering fix #1198

Merged

Conversation

DEVTomatoCake
Copy link
Member

  1. Fixes missing session (due to user being offline) or session status invisible being ignored when sorting members
  2. Fixes sort order to properly sort 1. by status, 2. by role position, 3. by username
  3. Removes TODO comment about typeorm .find() queries supporting ordering. This is supported now, however it's not possible to add custom select statements which would require the application to handle the ordering instead of the DB, which would require the limit in the query to be removed which wastes bandwidth.

@MaddyUnderStars MaddyUnderStars merged commit 7e60f8b into spacebarchat:master Aug 26, 2024
3 checks passed
@DEVTomatoCake DEVTomatoCake deleted the fix/lazy-request-filter branch August 26, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants