Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Cyborg Recharging Circuit Board from Lathe to Circuit Imprinter #34612

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Moved Cyborg Recharging Circuit Board from Lathe to Circuit Imprinter #34612

merged 1 commit into from
Jan 24, 2025

Conversation

Velken
Copy link
Contributor

@Velken Velken commented Jan 23, 2025

About the PR

Moved Borg Charger Circuitboard from autolathe to circuit imprinter

Why / Balance

People usually expect it to be in the circuit imprinter if they don't know it is in the auto-lathe.
Cyborgs are a "science thing" and therefore make more sense for the board for their recharger to be in the circuit impriter.

Technical details

Moved a line down from autolthe to circuitimprinter in lathe.yml

Requirements

Breaking changes

None as far as I am aware

Changelog

🆑

  • tweak: Moved Cyborg Charger Circuit Board from Auto Lathe to Circuit Imprinter.

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 23, 2025
@minthydra
Copy link

I mean yeah most people don’t even realise the circuit is in there let alone build it.
I see no real issue with this plus it slightly decluters the lathe’s crafting inventory.

@Velken Velken changed the title Moved Cyborg Recharging Cirbuit Board from Lathe to Circuit Imprinter Moved Cyborg Recharging Circuit Board from Lathe to Circuit Imprinter Jan 23, 2025
@minthydra
Copy link

No more cirbuit bad pr now

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Science Area: Science department, not including Silicons. A: Silicons Area: Relates to Silicon roles, including AI. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 23, 2025
@beck-thompson beck-thompson self-assigned this Jan 23, 2025
beck-thompson
beck-thompson approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, tested it and it works! 👍
Great first contribution!

@beck-thompson beck-thompson added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 24, 2025
@Emisse Emisse merged commit 613e710 into space-wizards:master Jan 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

Assignees

@beck-thompson beck-thompson

Labels
A: Science Area: Science department, not including Silicons. A: Silicons Area: Relates to Silicon roles, including AI. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Velken @minthydra @beck-thompson @Emisse @ArtisticRoomba