Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon resizing #34387

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Weapon resizing #34387

wants to merge 4 commits into from

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jan 11, 2025

About the PR

Added custom dimensions to every firearm, for better realism. Slightly nerfs the satchel too, by making it less able to carry a full-length assault rifle.

Why / Balance

This started as simply "why isn't the Enforcer 1x5?" and was quickly followed by other strange questions like "why is the assault rifle a square?". This has led me to change every single gun to have a somewhat more realistic and balanced inventory size.

Technical details

Custom dimensions were added to the item component of every firearm.

Media

image
image

Requirements

Changelog
🆑

  • tweak: the WT550, C20r, and disabler SMG are slightly smaller at 2x3.
  • tweak: The enforcer now matches the other shotguns at 1x5.
  • tweak: the China Lake, Hristov, and L6 are now quite big. Your back slot is suggested but not technically required.
  • tweak: the rifles take up a bit less space at 3x5.
  • tweak: laser rifles take up a lot less space at 2x5.
  • tweak: The advanced laser pistol is now much 2x2, making it more obvious why it doesn't fit in a pocket.
  • tweak: The Svalinn is now shaped like an actual pistol!
    -->

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/M Denotes a PR that changes 100-999 lines. labels Jan 11, 2025
@Nox38 Nox38 marked this pull request as ready for review January 12, 2025 01:19
@@ -53,6 +57,10 @@
id: WeaponSniperHristov
description: A portable anti-materiel rifle. Fires armor piercing 14.5mm shells. Uses .60 anti-materiel ammo.
components:
- type: Item
size: Huge
Copy link
Contributor

@kosticia kosticia Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hristov bundle didn't have enough space to contain rifle and all other items at one time

@kosticia
Copy link
Contributor

Great PR! But in my opinion satchels will be so much useless for antagonists and security, because biggest part of guns will be so much big for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants