Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Valves Resprite #34378

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Manual Valves Resprite #34378

wants to merge 2 commits into from
+1 −1

Conversation

Deerstop
Copy link
Contributor

About the PR

Resprites manual valves to have a more obvious indication of on/off status.

Why / Balance

Original sprite relied on a single red/green pixel to determine status, which for folks with red-green colourblindness, is unusable. The new sprite physically changes depending on status, meaning it should be much more obvious at a glance.

Technical details

Changed two sprites, and meta.json for credit

Media

Before:
pumpManualValveOn
pumpManualValve

After:
3

Requirements

Changelog

🆑

  • tweak: Improved the readability of the manual valve sprite.

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 11, 2025 •
edited
Loading

RSI Diff Bot; head commit a537306 merging into 3439b77
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Piping/Atmospherics/pump.rsi

State Old New Status
pumpManualValve Modified
pumpManualValveOn Modified

Edit: diff updated after a537306

Errant-4
Errant-4 requested changes Jan 11, 2025
View reviewed changes
Copy link
Member

@Errant-4 Errant-4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the PR

Resources/Textures/Structures/Piping/Atmospherics/pump.rsi/meta.json Outdated Show resolved Hide resolved
@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. A: Engineering Area: Engineering department, including Atmospherics. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 11, 2025
@Deerstop
Copy link
Contributor Author

Please link the PR

done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Errant-4 Errant-4 Errant-4 requested changes

@TheShuEd TheShuEd TheShuEd approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. A: Engineering Area: Engineering department, including Atmospherics. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Deerstop @Errant-4 @TheShuEd @lzk228