Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net 9 & Update submodule #34373

Closed
wants to merge 2 commits into from
Closed

Net 9 & Update submodule #34373

wants to merge 2 commits into from
+8 −8

Conversation

VasilisThePikachu
Copy link
Member

@VasilisThePikachu VasilisThePikachu commented Jan 11, 2025 •
edited
Loading

Breaking changes

Contribs need net9

Requirement for #33339 #34212 & #33787

Requires #34083
(otherwise it will spam 69 morbillion errors in console but otherwise game still works)

Merge space-wizards/docs#379 right after

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/XS Denotes a PR that changes 0-9 lines. S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 11, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 11, 2025
@VasilisThePikachu
Copy link
Member Author

With #34083 it tests fine

image
image

@PJB3005
Copy link
Member

PJB3005 commented Jan 11, 2025

#34320 good job now go to bed

@VasilisThePikachu
Copy link
Member Author

#34320 good job now go to bed

Bro when did you

@MaxSMokeSkaarj
Copy link

why close?

@K-Dynamic
Copy link
Contributor

why close?

duplicate of #34320

@VasilisThePikachu VasilisThePikachu deleted the net9-robust branch January 11, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 Awaiting requested review from PJB3005

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VasilisThePikachu @PJB3005 @MaxSMokeSkaarj @K-Dynamic