Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta hotfix #34306

Open
wants to merge 8 commits into
base: stable
Choose a base branch
from
Open

Meta hotfix #34306

wants to merge 8 commits into from
+8,047 −5,768

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jan 8, 2025 •
edited
Loading

About the PR

Fixes critical power and docking issues with my meta station overhaul

Why / Balance

currently, certain areas are always unpowered and the cargo shuttle doesn't have clearance.

Technical details

Media

Meta-0

Requirements

Breaking changes

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/08/25 21:42

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XL Denotes a PR that changes 5000+ lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 8, 2025
@ArtisticRoomba
Copy link
Contributor

change your branch this PR wants to merge into from space-wizards:master to space-wizards:stable by editing your PR at the top

@slarticodefast
Copy link
Member

change your branch this PR wants to merge into from space-wizards:master to space-wizards:stable by editing your PR at the top

Yeah, if this should be hotfixed (i.e. bypass the two week release cycle) you need to target the stable branch. Note that you cannot simply switch that on github without other commits being included as well. So you need to base your working branch off the stable branch.

@ArtisticRoomba
Copy link
Contributor

Yeah, if this should be hotfixed (i.e. bypass the two week release cycle) you need to target the stable branch. Note that you cannot simply switch that on github without other commits being included as well. So you need to base your working branch off the stable branch.

yeah I already made very sure she was doing her work off of the stable branch (was walking her through rider), she just needs to change the branch this PR is targeting

@slarticodefast
Copy link
Member

Ah, perfect. Then it will work. Errant was working on including the steps for this in the PR guidelines so it is less confusing by the way.

@ArtisticRoomba
Copy link
Contributor

oh shit she messed it up

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/08/25 23:06

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/08/25 23:15

@Nox38 Nox38 changed the base branch from master to stable January 9, 2025 18:14
@Nox38
Copy link
Contributor Author

Nox38 commented Jan 9, 2025

done!

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/09/25 19:32

@Nox38 Nox38 marked this pull request as ready for review January 9, 2025 19:32
@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/09/25 20:29

@Emisse
Copy link
Contributor

Emisse commented Jan 9, 2025

mapping approval needs 2 other approvals since its a hotfix

@slarticodefast
Copy link
Member

The diff is quite big, are you sure there aren't any other changes in here because of some git error?

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 9, 2025 •
edited
Loading

@slarticodefast fairly sure? I've tested the whole map. I don't know how other things would get into the map file, and there aren't other files changed

slarticodefast
slarticodefast approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't even look a the diff because it is too big and the map renderer is broken.
But if emisse says it's good I'll trust in that.

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 9, 2025

ill render it real fast

@HelpTheSteak
Copy link

Do you know about the one shuttle dock at sec facing the wrong way so nothing can dock to it

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 10, 2025

Do you know about the one shuttle dock at sec facing the wrong way so nothing can dock to it

yes, Im fixing it but unfortunately I didn't get it before the PR got its approvals, and I'm not sure if adding new things will remove the approvals . there are two major issues that need to be fixed ASAP, the rest can come a bit later.

@Emisse
Copy link
Contributor

Emisse commented Jan 10, 2025

you can update the pr

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 10, 2025

you can update the pr

oh neat!

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/10/25 08:31

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/10/25 19:17

@ArtisticRoomba
Copy link
Contributor

The diff is quite big, are you sure there aren't any other changes in here because of some git error?

looks fine to me in case you're still worried
image

ArtisticRoomba
ArtisticRoomba suggested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some oddities when looking at these changes in game:

  • Engineering has a 3 core AME suggestion mapped. It should be 6 cores, and they should get all of the flatpacks for a 6-core. (Wanna know something funny? Current stable Meta doesn't have enough flatpacks for a 6-core, so this is actually an important change).
  • A lot more of security should get holopads, while you're at it. Armory and the gearroom for example.
  • Engineering main should get a welding tank.

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/11/25 02:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtisticRoomba ArtisticRoomba ArtisticRoomba requested changes

@slarticodefast slarticodefast slarticodefast approved these changes

@Emisse Emisse Emisse approved these changes

Assignees
No one assigned
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/XL Denotes a PR that changes 5000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nox38 @ArtisticRoomba @slarticodefast @Emisse @HelpTheSteak