Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomized maints rooms #33619

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Spessmann
Copy link
Contributor

@Spessmann Spessmann commented Nov 28, 2024

About the PR

I used the roomfill vgroid exped gen thing to make some maints rooms.
Mostly made as a test, more rooms of are planned to be added edit: I added more. now we force jr mappers to make even more for us :trollface:

  • It is not mapped anywhere yet
  • rotation is randomized (note: because the orientation is randomized i needed to use spawners so the items would appear at the correct orientation. Also tileoverlay decals dont work properly with rotation so they are not used)
  • they are not wired, nor have lights in order to reduce conflicts with maps

Why / Balance

Randomized maints adds more variety

Media

image
image
image

Requirements

Changelog

no cl

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XL Denotes a PR that changes 5000+ lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. labels Nov 28, 2024
@Thatonestomf
Copy link
Contributor

Damn, this is really gonna change the maints experience.

@Spessmann
Copy link
Contributor Author

something something i need to add the prototype i made somewhere? I don't really know where

@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Mapping Area: Maps, or tools used for mapping and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 28, 2024
@muburu
Copy link
Contributor

muburu commented Nov 28, 2024

1 step closer to full procgen stations :godo:

@beck-thompson
Copy link
Contributor

Just FYI the test fail appears to be real!

@TheShuEd
Copy link
Member

You need to add Maints tag prototype
Use github search for
- type: Tag

@Ko4ergaPunk
Copy link
Contributor

What about wires?

@Spessmann
Copy link
Contributor Author

What about wires?

doesn't include wires or atmos, each maints may or may not choose to have them plus you cant really know where its gonna be (to avoid stacking wires) so its better just to have the mapper manually add it if they wish

@Spessmann
Copy link
Contributor Author

To fix the orientation issues (the orientation/rotation of each room is random when it is spawned) I'm going to replace the mapped items with spawners/crates/lockers

@SaphireLattice
Copy link
Contributor

As I understand, that spawns a room centered at a specific marker right?

It probably would be good to use two corner markers that are linked together somehow (same multitool linking even), so that rooms of different sizes are possible

@Spessmann
Copy link
Contributor Author

Spessmann commented Nov 30, 2024

As I understand, that spawns a room centered at a specific marker right?

It probably would be good to use two corner markers that are linked together somehow (same multitool linking even), so that rooms of different sizes are possible

No, it spawns the bottom left corner of the room at the marker

Rooms of different sizes are already possible

edit: i also didn't make this system, i hardly know how it works.

@ps3moira
Copy link
Contributor

is it only 5x5? no varying size?

@ps3moira
Copy link
Contributor

also zone code when 👀

@Spessmann
Copy link
Contributor Author

consistency is key

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. and removed size/XL Denotes a PR that changes 5000+ lines. labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Mapping Area: Maps, or tools used for mapping Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants