Containers block vision #33317
Containers block vision #33317
Conversation
github-actions
bot
added
size/M
TheShuEd
added
T: New Feature
|
works for lockers too? |
|
yes |
|
Not everything needs to be logical. This is just annoying. |
At least nukies might not need to gun down every disposal bin/locker if they do not want instant stunkill or something 🤔 Not taking damage when you are hiding in container is weird too but thats another issue I guess. |
TheShuEd
changed the title
SlamBamActionman
added
P2: Raised
|
I feel the vision blocking is a bit too harsh. It either should have a wider radius or it should gradually get worse. |
|
lockers have the eye slits you should be able to see out of them |
|
Maybe add the same block vision when player travel in disposal tube? |
I hate being that guy but ackshually not all lockers have slits. |
Yet somehow they are completely airtight |
SaphireLattice
added
the
S: Needs Review
|
The current implementation is very simple and just blinds the character completely. IIRC the blindness shader doesn't have a “range of visibility” parameter, so it's much harder to do. So currently, I'm not going to implement different levels of visibility for different container types, as that's out of scope. |
slarticodefast
added
the
S: Undergoing Maintainer Discussion
| /// <summary> | ||
| /// Blinds entities that are parented to this entity (are in this locker, crate or bag) | ||
| /// </summary> | ||
| [RegisterComponent] | ||
| public sealed partial class ChildBlockVisionComponent : Component | ||
| { | ||
| [DataField] | ||
| public bool Enabled = true; | ||
| } |
| base.Initialize(); | ||
|
|
||
| _transformQuery = GetEntityQuery<TransformComponent>(); | ||
| _blockQuery = GetEntityQuery<ChildBlockVisionComponent>(); | ||
| _mapQuery = GetEntityQuery<MapGridComponent>(); | ||
|
|
||
| SubscribeLocalEvent<EyeComponent, CanSeeAttemptEvent>(OnSeeAttempt); | ||
| SubscribeLocalEvent<EyeComponent, EntParentChangedMessage>(OnChangeParent); | ||
| } | ||
|
|
||
| private void OnChangeParent(Entity<EyeComponent> ent, ref EntParentChangedMessage args) | ||
| { | ||
| _blindable.UpdateIsBlind(ent.Owner); | ||
| } | ||
|
|
||
| private void OnSeeAttempt(Entity<EyeComponent> ent, ref CanSeeAttemptEvent args) | ||
| { | ||
| var parent = _transform.GetParentUid(ent); | ||
| if (HaveBlockVisionParent(parent)) | ||
| args.Cancel(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// recursively go through all parents up to the map. If one of the parents has a vision blocking component, we see nothing. | ||
| /// </summary> | ||
| private bool HaveBlockVisionParent(EntityUid ent) | ||
| { | ||
| if (!_transformQuery.HasComp(ent)) | ||
| return false; | ||
|
|
||
| if (_mapQuery.HasComp(ent)) | ||
| return false; | ||
|
|
||
| if (_blockQuery.TryComp(ent, out var block) && block.Enabled) | ||
| return true; | ||
|
|
||
| return HaveBlockVisionParent(_transform.GetParentUid(ent)); | ||
| } | ||
| } |
There was a problem hiding this comment.
This shouldn't be subscribing to directed events for engine components as this can very easily break in the future when the engine needs it.
| { | ||
| if (!_transformQuery.HasComp(ent)) | ||
| return false; | ||
|
|
||
| if (_mapQuery.HasComp(ent)) | ||
| return false; | ||
|
|
||
| if (_blockQuery.TryComp(ent, out var block) && block.Enabled) | ||
| return true; | ||
|
|
||
| return HaveBlockVisionParent(_transform.GetParentUid(ent)); | ||
| } |
There was a problem hiding this comment.
You're resolving the transformcomponent twice, once unnecessarily.
Remove the transformqueryhascomp.
metalgearsloth
added
S: Awaiting Changes
|
Keron is against this kind of implementation of these mechanics, and proper implementation means working with shaders, which I'm not ready for. |
About the PR
Containers can now block vision for entities that sit within it.
Why / Balance
Logic
Media
2024-11-14.21-16-05.mp4
Requirements
Changelog
🆑