Ion storm refactor #33311
Merged
Ion storm refactor #33311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which also uses IonStormSystem. Added StartIonStormedComponent. Changed stuff related to the Derelict Cyborg. Derelict Cyborg now spawns with a randomized lawset.
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
…ture Cyborgs and AI's, including those in subsequent rounds.
…h i didn't want to.
…screen. It still appears in the Player Manifest.
…relict Cyborg right now) not showing up as 'antag' in the admin player overlay.
github-actions
bot
added
the
Changes: Sprites
slarticodefast
added
A: Silicons
SaphireLattice
added
S: Needs Review
github-actions
bot
added
S: Needs Review
slarticodefast
requested changes
Nov 17, 2024
slarticodefast
added
S: Awaiting Changes
github-actions
bot
added
S: Needs Review
slarticodefast
approved these changes
Nov 17, 2024
slarticodefast
added
S: Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Taking the ion storm refactor out of #32499 to keep it on a seperate PR
Fixes #31485
Why / Balance
Technical details
Seperated the IonStormRule to use an IonStormSystem. Now those with silicon laws can be IonStormed without relying on the event.
Media
Nuh uh.
Requirements
Breaking changes
The logic handling Ion Storms has been moved out of IonStormRule into a new IonStormSystem. Any logic added downstream must be moved there as well.
Ion Storms affecting Silicons is now handled by the IonStormTarget function under the new system.
SiliconLawProvider now has a new subverted field that handles whether the silicon has non-default laws and the AntagonistRole field has been removed from EmaggedSiliconComponent.
EnsureEmaggedRole is now EnsureSubvertedSilicon role and uses the MindId instead of the Entity.
Changelog
🆑 ScarKy0, GoldenCan
ADMIN: