Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codeowners cleanup #33297

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Codeowners cleanup #33297

merged 3 commits into from
Dec 8, 2024

Conversation

VasilisThePikachu
Copy link
Member

About the PR

Clean up the codeowners

Why / Balance

  • Remove maints who left the project
  • Change out Chief engi with nik. Our new headmin
  • Add JuanLuc (IProduceWidgets) per request they dont have write access scratch that

Requirements

@VasilisThePikachu
Codeowners cleanup
7997463 
Changelog: 
- Remove maints who left the project
- Change out Chief engi with nik. Our new headmin
- Add JuanLuc (IProduceWidgets) per request
@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Nov 13, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@TheShuEd TheShuEd added T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 14, 2024
@SaphireLattice SaphireLattice added A: Core Tech Area: Underlying core tech for the game and the Github repository. P1: High Priority: Higher priority than other items, but isn't an emergency. labels Nov 15, 2024
@whateverusername0

This comment was marked as off-topic.

Sign in to view
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Nov 21, 2024
@VasilisThePikachu
Copy link
Member Author

Notafet approved this pr via discord, two successful (including me) approvals collected.

@VasilisThePikachu VasilisThePikachu merged commit 337952d into master Dec 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VasilisThePikachu @whateverusername0 @SaphireLattice @SlamBamActionman @TheShuEd