Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mime outfit partial resprite #33293

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Mime outfit partial resprite #33293

wants to merge 4 commits into from

Conversation

UbaserB
Copy link
Member

@UbaserB UbaserB commented Nov 13, 2024 •
edited
Loading

About the PR

Resprites the mime jumpsuit, jumpskirt, winter coat, masks, and worn suspender sprites. This is not the full outfit resprited, but nearly.
It still kind of looks off to me, so I'm going to be discussing it with the other Art Leads before it's ready.

Why / Balance

It was an ancient sprite and looked kinda ugly, the shading was flat and the outlines were inconsistent/messy especially considering the stripy nature of the mime suit.

Media

image

image

Requirements

Changelog

🆑 Ubaser

  • tweak: The Mime's outfit is partially resprited.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

RSI Diff Bot; head commit 35f998c merging into 99b4604
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Belt/suspenders_black.rsi

State Old New Status
equipped-BELT Modified

Resources/Textures/Clothing/Belt/suspenders_red.rsi

State Old New Status
equipped-BELT Modified

Resources/Textures/Clothing/Mask/mime.rsi

State Old New Status
equipped-MASK-hamster Modified
equipped-MASK-reptilian Modified
equipped-MASK-vox Modified
equipped-MASK Modified
icon Modified

Resources/Textures/Clothing/Mask/sadmime.rsi

State Old New Status
equipped-MASK-reptilian Modified
equipped-MASK-vox Modified
equipped-MASK Modified
icon Modified

Resources/Textures/Clothing/Mask/scaredmime.rsi

State Old New Status
equipped-MASK-reptilian Modified
equipped-MASK-vox Modified
equipped-MASK Modified
icon Modified

Resources/Textures/Clothing/Mask/sexymime.rsi

State Old New Status
equipped-MASK-reptilian Modified
equipped-MASK-vox Modified
equipped-MASK Modified
icon Modified

Resources/Textures/Clothing/OuterClothing/WinterCoats/coat.rsi

State Old New Status
MIME-equipped-OUTERCLOTHING-vox Modified
MIME-equipped-OUTERCLOTHING Modified
MIME-icon Modified
MIME-inhand-left Modified

Resources/Textures/Clothing/Uniforms/Jumpskirt/mime.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Modified
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Uniforms/Jumpsuit/mime.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Modified
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified

@UbaserB UbaserB changed the title Mime outfit resprite Mime outfit partial resprite Nov 13, 2024
@ImWeax
Copy link
Contributor

ImWeax commented Nov 13, 2024

The default mime mask should remain unchanged - it's an iconic look

@UbaserB
Copy link
Member Author

UbaserB commented Nov 13, 2024

The default mime mask should remain unchanged - it's an iconic look

its currently being discussed so just wait until review gets reviewed and whatnot

@Everturning
Copy link

add the green back to the eyes

@Everturning
Copy link

@UbaserB I'm seeing what's off here with the resprites (as a player anyhow) - looking at other jumpsuits, you're adding too much grey to the arms and some of the torso.
It's also so much more visually complex than the other jumpsuits and coats and such in general that it's jarring.

@UbaserB
Copy link
Member Author

UbaserB commented Nov 14, 2024

going to draft for now as I work on it, I probably should have drafted from the start but I'm a dumby.

@UbaserB UbaserB marked this pull request as draft November 14, 2024 11:15
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@SaphireLattice SaphireLattice added P3: Standard Priority: Default priority for repository items. D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Art Area: Art with no implications for other areas. A: Service Area: Service department, including cooking, botany, etc T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 15, 2024
@Sadie-silly
Copy link
Contributor

The default mime mask should remain unchanged - it's an iconic look

its currently being discussed so just wait until review gets reviewed and whatnot

Just throwing an idea out there, I think the default should definitely get resprited, but the original should stay in the game as a separate item, maybe as a rare maints loot.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@UbaserB @ImWeax @Everturning @Sadie-silly @SaphireLattice @SlamBamActionman