Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds space ticks to vent spawn event #33190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

K-Dynamic
Copy link
Contributor

@K-Dynamic K-Dynamic commented Nov 6, 2024

About the PR

Adds space ticks to vent spawn event.

Why / Balance

Not enough variety in the vent spawn event, and ticks seemed to make sense as infestations on space stations.

They are fast, bunch up and inject a lot of poison, but are easy to take down with two or so crowbar swings.

Technical details

yml changes only

  • Resources/Prototypes/GameRules/events.yml (adds space ticks game rule and event itself)

Requirements

Breaking changes

N/A

Changelog

🆑

  • add: Vent spawns may now include space ticks.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Nov 6, 2024
@TheShuEd TheShuEd added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Nov 7, 2024
@K-Dynamic
Copy link
Contributor Author

K-Dynamic commented Nov 8, 2024

Testing alone on Bagel, I killed about 9 or so ticks around the station. Most of them were alone but there were a few groupings of two or three.

They are very easy to dispatch but inject a lot of poison, probably won't pose as much threat compared to spiders

@SlamBamActionman SlamBamActionman added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Nov 8, 2024
@SlamBamActionman
Copy link
Member

Maintainer team is discussing this type of PR at the moment, as merely adding a new vent creature event increases the overall chance for vent spawns, which can make that type of event happen more often than desirable. #32742 is an example of this being observed. We'll get back to you once the discussion has finished.

@K-Dynamic
Copy link
Contributor Author

Maintainer team is discussing this type of PR at the moment, as merely adding a new vent creature event increases the overall chance for vent spawns, which can make that type of event happen more often than desirable. #32742 is an example of this being observed. We'll get back to you once the discussion has finished.

Is it not possible to just proportionally reduce weights for each new added vent event

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@SaphireLattice SaphireLattice added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities T: New Feature Type: New feature or content, or extending existing content and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 15, 2024
@metalgearsloth
Copy link
Contributor

Maintainer team is discussing this type of PR at the moment, as merely adding a new vent creature event increases the overall chance for vent spawns, which can make that type of event happen more often than desirable. #32742 is an example of this being observed. We'll get back to you once the discussion has finished.

Is it not possible to just proportionally reduce weights for each new added vent event

Using the same spawn table is far easier than manually curating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants