Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APCs are now usable by multiple entities at the same time, with no jank! #32356

Closed

Conversation

hyphenationc
Copy link
Contributor

About the PR

  • APCs can now be used by multiple users, including the AI, at the same time.
  • The Toggle button on APCs no longer gets disabled.

Why / Balance

#32312 exposed a bit of detail where the AI was capable of preventing people from physically toggling APCs, regardless of access. At the very least, the AI will have to fight for it now, as multiple users can fight over the toggle switch if they have the right access.
Those unable to toggle the breaker before are still unable, the button will just tell them "insufficient access" instead of being disabled.

Technical details

The code had 2 different methods by which access was determined, one was tied to disabling the button - that method is entirely removed. Technically, this doesn't solve the TODO in ApcSystem.cs ("this should be per-player not stored on the apc"), so I've left that comment in - maints can remove it if they want.
This does mean it's now the server's responsibility to reject button toggles, so people can spam the button. I have no way to test if this makes the implemented solution non-viable.
If the removed HasAccess method is desirable to be returned for whatever reason, that can be done - but be warned it causes a lot of jank, and would need singleUser within apc.yml to be made true again.

Media

Requirements

Breaking changes

Removes HasAccess arguments and variables from APCs entirely. Not certain this will break anything, but it doesn't have a replacement.
Changelog

🆑

  • tweak: APCs can now be interacted with by multiple users, preventing AI from completely stalling out control.

@github-actions github-actions bot added the Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design label Sep 21, 2024
@hyphenationc
Copy link
Contributor Author

Revised version of [32325] to fix jank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant