Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criminal Records Computer Better UX + Filtering #32352

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamessimo
Copy link
Contributor

About the PR

Updated the criminal records computer to have some new features, these are;

  • Show crews jobs and job icon
  • Show criminal status icon
  • Allow for multiline wanted and suspect reasons
  • Ability to filter the criminal record types
  • Fixed a bug where "Suspect" and "Wanted" where used incorrectly.
  • Tweaks to the UI

Why / Balance

When you are joining mid round, there is no way to know who is wanted/detained and on parole unless you manually click through the criminal records. This allows new officers to quickly catch up on whos wanted and for what. Also nice to see jobs because a name would be wanted but no indication of what there job is.

Technical details

Added a new CriminalRecordSetStatusFilter method, this is a int of 0 to 3 which is mapped to CriminalRecord.Status. Also removed some hard coded colors in the locals file.

Orginally this used tabs but the tabs were not the correct method since I didn't want a completely new UI per tab and just needed to filter the stations records according to their criminal record status.

I accidently included a .vscode config file, didn't notice until now and not sure if that will cause an issue.

Media

image

Requirements

Breaking changes

Changelog

🆑

  • tweak: Criminal Records computer got enhanced UX & UI
  • tweak: Criminal Records computer can now filter its list against crew criminal status

@github-actions github-actions bot added Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged. labels Sep 21, 2024
@Moomoobeef
Copy link
Contributor

Moomoobeef commented Sep 21, 2024

you could add a print button and a dropdown to have criminal records be printable to a fax machine, but that might be out of scope for this PR.

@thebadman4662
Copy link

When you are joining mid round, there is no way to know who is wanted/detained and on parole unless you manually click through the criminal records.

Small correction here, we now have wanted lists in PDA showing only criminals, their age, species and job on top of their status. But of course even better criminal records never hurt.

@jamessimo
Copy link
Contributor Author

you could add a print button and a dropdown to have criminal records be printable to a fax machine, but that might be out of scope for this PR.

That was on my plate to do and I even designed it but getting the filtering to work took way too much time. I will make another PR later with that and embed the crime history onto the main console window as outlined in #24646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants