Criminal Records Computer Better UX + Filtering #32352
Open
+312
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Updated the criminal records computer to have some new features, these are;
Why / Balance
When you are joining mid round, there is no way to know who is wanted/detained and on parole unless you manually click through the criminal records. This allows new officers to quickly catch up on whos wanted and for what. Also nice to see jobs because a name would be wanted but no indication of what there job is.
Technical details
Added a new CriminalRecordSetStatusFilter method, this is a int of 0 to 3 which is mapped to CriminalRecord.Status. Also removed some hard coded colors in the locals file.
Orginally this used tabs but the tabs were not the correct method since I didn't want a completely new UI per tab and just needed to filter the stations records according to their criminal record status.
I accidently included a .vscode config file, didn't notice until now and not sure if that will cause an issue.
Media
Requirements
Breaking changes
Changelog
🆑