Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding intellicard functionality. #32347

Merged
merged 18 commits into from
Oct 22, 2024

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Sep 21, 2024

About the PR

Intellicards can now be used to remove/insert the current AI from the core.
Slight intellicard sprite update.

Why / Balance

Killing AI makes sense... I think

Technical details

The brain slot on intellicards and ai core is unlocked but cannot eject, making intellicards swap the brain between itself and the core.
AI Eye gets deleted/created on adding or removing ai from the core to fix a bug where the AI Eye would stay visible forever after being removed.
InstrinsicUI now removes all actions it granted on shutdown. Seeing it was only used on AI and Aghost and after some testing it seems to be working all fine.

Media

8mb.video-7jm-9WgrZoJG.mp4

Requirements

Breaking changes

InstrinsicUI now removes all actions it granted on shutdown. Unsure if this is a breaking change or not.

Changelog

🆑 ScarKy0, Fildrance

  • add: Using an intellicard on the AI core now swaps the AI between the core and intellicard. (You can evac with the AI!)
  • add: Added an intellicard to the RD's locker.

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 21, 2024

If someone knows how to do anything in the TODO please tell me because I don't 😭

@deltanedas
Copy link
Contributor

Make swapping the brain a doAfter.

i think ItemSlot has a field for this that rmc added

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 21, 2024

i think ItemSlot has a field for this that rmc added

From what ive seen ItemSlotsComponent doesnt have a field for doAfter, unless im missing something

@github-actions github-actions bot added the Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. label Sep 21, 2024
Copy link
Contributor

github-actions bot commented Sep 21, 2024

RSI Diff Bot; head commit e1861c6 merging into ac16a05
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/ai_card.rsi

State Old New Status
base Modified
empty Modified
full Modified

Edit: diff updated after e1861c6

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 21, 2024

God bless fildrance

@ScarKy0 ScarKy0 marked this pull request as ready for review September 21, 2024 22:50
@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 21, 2024
@superjj18
Copy link
Contributor

Just need to make ai cores buildable and anchorable and then AI’s can successfully be revived after being disconnected from the station.

@AverageNotDoingAnythingEnjoyer

Maybe it shouldn't spawn in RD locker for now, as AI still doesn't have ways to protect itself against an antag breaking in and carding them

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Oct 9, 2024
Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the PAI stuff for now I reckon.

@metalgearsloth metalgearsloth removed the Status: Needs Review This PR requires new reviews before it can be merged. label Oct 14, 2024
@metalgearsloth metalgearsloth added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Oct 14, 2024
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Oct 14, 2024

Well shit its all on fire

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 16, 2024
@slarticodefast slarticodefast merged commit 9873efd into space-wizards:master Oct 22, 2024
13 checks passed
@slarticodefast
Copy link
Member

Tested in-game and works as intended.

@superjj18
Copy link
Contributor

Can we perhaps remove mapped intellicards and instead put one in RD's locker?

@LGRuthes
Copy link
Contributor

Make the intelicard require a lenghty do-after like disarming the nuke does. That way someone can't just suicide rush into AI chamber and intelicard them away, and also provides a MALF AI or just regular AI in general the chance to warn crew or fight back before they are completely neutralized. Perhaps even make it tell the AI "hey someone is uploading you into an Intelicard!"

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Oct 23, 2024

Make the intelicard require a lenghty do-after like disarming the nuke does. That way someone can't just suicide rush into AI chamber and intelicard them away, and also provides a MALF AI or just regular AI in general the chance to warn crew or fight back before they are completely neutralized. Perhaps even make it tell the AI "hey someone is uploading you into an Intelicard!"

Thats the plan!
I will be trying to do something similiar when I continue working on intellicards after this, for now this serves as a basic way to be able to kill the AI

Can we perhaps remove mapped intellicards and instead put one in RD's locker?

There is one in RD's locker but I know nothing of mapping to remove the mapped ones

iaada pushed a commit to iaada/space-station-14 that referenced this pull request Nov 9, 2024
* init

* im so confused

* clean

* sprite update

* :|

* further attempts

* be blessed for it works

* Very prestigious pAI

* cleaning up

* Intellicard in RD locker

* PAIn't

* .Clear()n't

* .Clear()n't for real this time

* Cleaning up

* Whoopsie Daisy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants