Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNA transfers to result of a chemical reaction #32341

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kandiyaki
Copy link

About the PR

Why / Balance

this is mostly just a precursor to things i'm working on in #31614 - however, it'll also allow detectives to find out whose blood some things are made out of.

Technical details

  • added a new tag, preserveDNA, to chemical reaction recipes.
  • if a recipe has preserveDNA, a slight modification to the ChemicalReactionSystem makes DNA transfer to reactions' products.
  • added preserveDNA to all recipes that seemed appropriate (and also blessing blood into wine because it's funny).

Media

video showing changes:
https://www.youtube.com/watch?v=ckEHuYtsd-M

Requirements

Breaking changes

this does slightly change up how reactions occur in the ChemicalReactionSystem, but all my testing indicated that I didn't break anything. hopefully.

Changelog

🆑

  • tweak: DNA from reagents such as blood and slime will now transfer to the resulting chemical if used in a recipe.

@@ -73,6 +73,7 @@

- type: reaction
id: SpaceGlue
preserveDNA: true
minTemp: 370
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldnt the dna break down at this temperature

@Kandiyaki
Copy link
Author

surprisingly, no!
Screenshot_20240921_004356_Chrome
Screenshot_20240921_004423_Chrome

even if it did, i think the funny of learning who's in your space glue trumps the realism of DNA breakdown

@deltanedas
Copy link
Contributor

ok real

i think better way of having this would be always transfer reagent data, then have a separate system to destroy data above that temperature

@Kandiyaki
Copy link
Author

i think better way of having this would be always transfer reagent data, then have a separate system to destroy data above that temperature

do you mean always transfer reagent data for every reaction? i'm a little hesitant about doing that, since the transfer requires scanning all the data in all the reagents, which sounds like it could get laggy. also i'm not sure if DNA destruction at a certain heat would really be within the scope of this PR.

@Kandiyaki Kandiyaki mentioned this pull request Oct 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants