Remove all command age requirements

[VasilisThePikachu]

About the PR

Removes the age requirements from command jobs

Why / Balance

From what I can tell this was merged with this on accident.

Maintainers see the maint review thread on this.

The original pr also claimed this was as an example. #30347

In my opinion wizden should not have an age requirement for command.

Note to everyone: FORKS CAN REVERT THIS, this pr is being made for wizard den and targeting the LRP servers

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑 Vasilis

• tweak: Removed the age requirement for command jobs.

[Ertanic]

Maybe you should have just made it a matter of disabling the age restriction via cvar? If some fork really doesn't need that.

[VasilisThePikachu]

Maybe you should have just made it a matter of disabling the age restriction via cvar?

Are you concerned about forks? Forks may revert this with git if it gets merged.

Also, a cvar does not really make sense here.

[0x6273]

From what I can tell this was merged with this on accident.

No, that PR has a changelog entry so it's definitely not an accident.

In my opinion wizden should not have an age requirement for command.

"In my opinion" is not a very good explanation for making a change like this. Could you explain why do you hold that opinion?

[VasilisThePikachu]

From what I can tell this was merged with this on accident.

No, that PR has a changelog entry so it's definitely not an accident.

And it was in an RP way, which goes against our policy. Anyhow, in the pr description you can see how it's explained to be "As an example". Internal maintainer review noticed this as well after being merged. With the idea that it would be fine to revert this if it ended up being a problem. (This chatter was between 2 people. The only people reviewing it)

Along with that, something else was amiss during the review of this pr, which I will cover next

In my opinion wizden should not have an age requirement for command.

"In my opinion" is not a very good explanation for making a change like this. Could you explain why do you hold that opinion?

Now yes I made this pr with a headache and it was late. So let me explain further.

In upstream as of currently we do not want to restrict player creation. And as the maintainer review is going currently. All participating maintainers agree.

Yes, it is silly that an 18-year-old can be a captain from a rp standpoint, which from a quick chat (And also recognizing some names) I had seems to be why most of the downvotes are there. Most of our servers are LRP and we do not have a lore. And it feels like a weird limitation to have on Wizard den servers. Hell, even then. I wouldn't mind seeing someone explain how to get captain at the age of 18. It gets people role-playing and creating a story. I could be stretching this here, but i would believe this falls under the seriously silly pillar

The second part of this story is that, this feature getting into upstream was not even talked with other maintainers. The species team (which I'm part of) was NOT notified about this change. I only found out after someone asked about it in the general chat on discord.

Normally, we use the work groups system to alert maintainers that are interested in a certain part of the game about changes and to give their opinions. This did not happen, I do not blame anyone for the slip up. We are human, after all. But I believe now that we have noticed this, we believe that it should have not made it into the game.