Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job title localization #32338

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chavonadelal
Copy link
Contributor

@chavonadelal chavonadelal commented Sep 20, 2024

About the PR

localizing job title. Replaced all uses of JobTitle with LocalizedJobTitle.

Fixes #28791

Why / Balance

Technical details

Media

Requirements

Breaking changes

Changelog

🆑 to4no_fix

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 20, 2024
@beck-thompson
Copy link
Contributor

Strongest localization warrior 💪 💪 💪

@chavonadelal
Copy link
Contributor Author

Strongest localization warrior 💪 💪 💪

Start your day with game localization! 🥤

@chavonadelal
Copy link
Contributor Author

Everything is fixed and working

@lzk228
Copy link
Contributor

lzk228 commented Sep 21, 2024

fixes #28791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JobTitle field in IdCardComponent should support locale strings
3 participants