Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more gas tanks to suit lockers. #32324

Closed
wants to merge 2 commits into from

Conversation

BramvanZijp
Copy link
Contributor

@BramvanZijp BramvanZijp commented Sep 20, 2024

About the PR

Adds a nitrogen tank to all suit lockers.
Adds extended oxygen and nitrogen tanks to engi, atmos, and security suit lockers.
Adds double extended emergency oxygen and nitrogen tanks to command suit lockers.

Why / Balance

The nitrogen should be self explanetory, theres plenty of species which use nitrogen now and they should be considered.
As for the extended for engi atmos and sec, they will need to use space semi-often, engi and atmos need it regularly, while security will need it for extended periods of time while their backslot is clear for a weapon
Heads also need space surprisingly often, with a lot of them having better things to put on their back, and them having to go to EVA in some maps or scrounge through maints in ones that dont have them mapped to get better pocket tanks feels wrong. I feel like they should get these roundstart, especially since some maps have them mapped while all of them can have them spawn in maints.

Media

Unneccesary

Requirements

Changelog

🆑 BramvanZijp

  • add: Engineering, Atmos and Security Hardsuit lockers now come with Extended Emergency Tanks, while heads of staff get double emergency tanks in their lockers.
  • tweak: Suit lockers now also come with nitrogen tanks instead of just oxygen.

@github-actions github-actions bot added the No C# For things that don't need code. label Sep 20, 2024
@Plykiya
Copy link
Contributor

Plykiya commented Sep 20, 2024

I believe maintainers specifically want to avoid doing this because of the entity bloat it introduces but I could be wrong

@BramvanZijp
Copy link
Contributor Author

I believe maintainers specifically want to avoid doing this because of the entity bloat it introduces but I could be wrong

I feel like its not that bad, and it doesnt make sense to ignore the nitrogen breathing species for this reason.

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Sep 20, 2024
@Plykiya
Copy link
Contributor

Plykiya commented Sep 20, 2024

I believe maintainers specifically want to avoid doing this because of the entity bloat it introduces but I could be wrong

I feel like its not that bad, and it doesnt make sense to ignore the nitrogen breathing species for this reason.

the conclusion every time nitrogen tanks are added wherever oxygen tanks are is "it makes it so that there aren't any differences (downsides) between the species" but you're left with extra nitrogen tanks everywhere for the very few pure-nitrogen breathing species on station

@TheDoctor1977
Copy link

the conclusion every time nitrogen tanks are added wherever oxygen tanks are is "it makes it so that there aren't any differences (downsides) between the species"

this reasoning was used in #25660 but now that we have vox, which can only breathe nitrogen, unlike slimes which can get by on a regular air mix, we should revisit readding them to at least a few places, though i agree that just putting them anywhere oxygen tanks are is too bloaty

@BramvanZijp
Copy link
Contributor Author

For the record, theres 2 main parts to this PR: Adding the extended & double tanks, and the nitrogen. If maintainers want to deny one but accept the other, let me know and ill update the PR accordingly.

@slarticodefast
Copy link
Member

Hey, we had a vote among the maintainers and the result was to close this PR. The main reason stated in the discussion was that N2 is supposed to be scarce on purpose to not make the difference between species trivial.
For department heads we want them to focus on doing their job and not go and do everything themselves. This addition would further motivate them to go off into space.
Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants