Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks to reset buttons in construction menu on close #32319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VerinSenpai
Copy link

@VerinSenpai VerinSenpai commented Sep 20, 2024

About the PR

Fixed an issue where closing the construction menu while erase or build mode is active leaves those functions toggled and keeps certain top menu functions and interactions disabled.

Why / Balance

The issue is that with erase mode active in particular, there is no indication that erase mode is still active as the window is gone and the top menu button has toggled off. This leads to confusion as you are unable to perform certain interactions and shortcuts with no indication as to what is causing it.

Technical details

I wanted to get some feedback on this as the implementation may be poor or the issue may be intentional and just in need of some tweaking. I moved the code handling EraseButtonToggled to its own function similar to BuildButtonToggled and then added checks for both to reset them upon closing the window.

Media

2024-09-19.22-56-12.mp4

Requirements

Breaking changes

No breaking changes to note.

Changelog

🆑

  • fix: Build and erase modes no longer remain active upon closing the construction menu.

@Golinth
Copy link
Contributor

Golinth commented Sep 21, 2024

God bless, as a new player this confused me so fucking much

@VerinSenpai VerinSenpai marked this pull request as draft September 24, 2024 11:16
@VerinSenpai VerinSenpai marked this pull request as ready for review September 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants