Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIM have Passenger Access. #32302

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Conversation

Jophire
Copy link
Contributor

@Jophire Jophire commented Sep 19, 2024

About the PR

The VIM mech now has the same access as a passenger.

Why / Balance

Currently its possible to get stuck inside doors if not moving fast enough.
It is still possible to get stuck behind Fire Doors.

Technical details

Added to MechVim in mechs.yml

- type: Access
    tags:
    - Maintenance

Media

output2.webm

Requirements

Changelog

🆑

  • add: VIM mech now can open maintenance doors!

This reverts commit 4a44065.
This reverts commit fb5db29.
Vim No longer gets stuck in doors.
@github-actions github-actions bot added the No C# For things that don't need code. label Sep 19, 2024
@baddiePRO
Copy link

why do monkeys need vims? they can wear EVA suits just fine

@slarticodefast
Copy link
Member

slarticodefast commented Sep 19, 2024

Hey, thank you for your first contribution!
Quick review:

  • The DoorBumpOpenener should be already inherited from BaseMech, so are you sure this even changes anything? Furthermore, it would actually remove some of the tags since they are overwritten.
  • According to the PR guidelines, please avoid web edits and test all changes in-game before making a PR. Have a look at our documentation to learn how to use git and an IDE.
  • Add a video or screenshots to your PR description to show your changes have been tested and work as intended.

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 19, 2024
@Jophire
Copy link
Contributor Author

Jophire commented Sep 19, 2024

Sorry, I tested on the debug admin map instead of on an actual map. Did not realize the departments on the admin map are not actually locked behind access restrictions. This pull can be closed till I figure out a different solution.

Debug Tested on the wrong map. Much easier solution. Just give the mech Access tags.
@Jophire
Copy link
Contributor Author

Jophire commented Sep 19, 2024

why do monkeys need vims? they can wear EVA suits just fine

Oh that is just default behavior, but if vims had access to a greater amount of the map, then it becomes a target for mischief. That is why I mentioned monkeys, as one of the only vim pilots with hand interactions.

@Jophire Jophire changed the title VIM can open Doors. VIM have Passenger Access. Sep 19, 2024
Moved access tag to the non-admin VIM.
@slarticodefast slarticodefast added Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Sep 20, 2024
@slarticodefast
Copy link
Member

Thank you for your contribution and your first PR :)

@slarticodefast slarticodefast merged commit 24140d8 into space-wizards:master Sep 23, 2024
11 checks passed
Ilya246 pushed a commit to Ilya246/space-station-14 that referenced this pull request Oct 7, 2024
* Revert "Update mechs.yml"

This reverts commit 4a44065.

* Reapply "Update mechs.yml"

This reverts commit fb5db29.

* Revert "Reapply "Update mechs.yml""

This reverts commit c845b6b.

* Reapply "Reapply "Update mechs.yml""

This reverts commit 41b8934.

* VIM Door Stuck Fix

Vim No longer gets stuck in doors.

* VIM has Passenger Access

Debug Tested on the wrong map. Much easier solution. Just give the mech Access tags.

* Moved tags to proper VIM.

Moved access tag to the non-admin VIM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants