Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

great organs reparenting #32300

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Sep 19, 2024

reparented all organs

before

graph in text
digraph {
BaseItem -> BaseAnimalOrganUnGibbable ;
BaseAnimalOrganUnGibbable -> BaseAnimalOrgan ;
BaseAnimalOrgan -> OrganAnimalLungs ;
BaseAnimalOrgan -> OrganAnimalStomach ;
OrganAnimalStomach -> OrganMouseStomach ;
BaseAnimalOrgan -> OrganAnimalLiver ;
BaseAnimalOrgan -> OrganAnimalHeart ;
BaseAnimalOrgan -> OrganAnimalKidneys ;
OrganAnimalStomach -> OrganBloodsuckerStomach ;
OrganAnimalLiver -> OrganBloodsuckerLiver ;
OrganAnimalHeart -> OrganBloodsuckerHeart ;
OrganAnimalStomach -> OrganAnimalRuminantStomach ;
BaseItem -> SentientSlimesCore ;
OrganHumanBrain -> SentientSlimesCore ;
BaseHumanOrgan -> OrganSlimesLungs ;
BaseItem -> BaseArachnidOrgan ;
OrganAnimalStomach -> OrganArachnidStomach ;
BaseArachnidOrgan -> OrganArachnidLungs ;
BaseArachnidOrgan -> OrganArachnidHeart ;
BaseHumanOrgan -> OrganArachnidLiver ;
BaseHumanOrgan -> OrganArachnidKidneys ;
BaseArachnidOrgan -> OrganArachnidEyes ;
BaseArachnidOrgan -> OrganArachnidTongue ;
BaseItem -> BaseDionaOrgan ;
BaseDionaOrgan -> OrganDionaBrain ;
OrganHumanBrain -> OrganDionaBrain ;
BaseDionaOrgan -> OrganDionaEyes ;
BaseDionaOrgan -> OrganDionaStomach ;
BaseDionaOrgan -> OrganDionaLungs ;
OrganDionaBrain -> OrganDionaBrainNymph ;
OrganDionaStomach -> OrganDionaStomachNymph ;
OrganDionaLungs -> OrganDionaLungsNymph ;
MobDionaNymph -> OrganDionaNymphBrain ;
MobDionaNymphAccent -> OrganDionaNymphStomach ;
MobDionaNymphAccent -> OrganDionaNymphLungs ;
OrganHumanHeart -> OrganDwarfHeart ;
OrganHumanLiver -> OrganDwarfLiver ;
OrganHumanStomach -> OrganDwarfStomach ;
BaseItem -> BaseHumanOrganUnGibbable ;
BaseHumanOrganUnGibbable -> BaseHumanOrgan ;
BaseHumanOrganUnGibbable -> OrganHumanBrain ;
BaseHumanOrgan -> OrganHumanEyes ;
BaseHumanOrgan -> OrganHumanTongue ;
BaseHumanOrgan -> OrganHumanAppendix ;
BaseHumanOrgan -> OrganHumanEars ;
BaseHumanOrgan -> OrganHumanLungs ;
BaseHumanOrgan -> OrganHumanHeart ;
BaseHumanOrgan -> OrganHumanStomach ;
BaseHumanOrgan -> OrganHumanLiver ;
BaseHumanOrgan -> OrganHumanKidneys ;
OrganAnimalStomach -> OrganMothStomach ;
OrganHumanStomach -> OrganMothStomach ;
OrganHumanLungs -> OrganRatLungs ;
OrganAnimalStomach -> OrganRatStomach ;
OrganAnimalStomach -> OrganReptilianStomach ;
BaseItem -> SentientSlimeCore ;
OrganHumanBrain -> SentientSlimeCore ;
BaseHumanOrgan -> OrganSlimeLungs ;
OrganHumanLungs -> OrganVoxLungs ;
}

out

after

graph in text
digraph {
OrganAnimalStomach -> OrganMouseStomach ;
OrganAnimalStomach -> OrganBloodsuckerStomach ;
OrganAnimalLiver -> OrganBloodsuckerLiver ;
OrganAnimalHeart -> OrganBloodsuckerHeart ;
OrganAnimalStomach -> OrganAnimalRuminantStomach ;
SentientSlimeCore -> SentientSlimesCore ;
OrganSlimeLungs -> OrganSlimesLungs ;
OrganAnimalStomach -> OrganArachnidStomach ;
BaseArachnidOrgan -> OrganArachnidStomach ;
BaseOrganLungs -> OrganArachnidLungs ;
BaseArachnidOrgan -> OrganArachnidLungs ;
BaseOrganHeart -> OrganArachnidHeart ;
BaseArachnidOrgan -> OrganArachnidHeart ;
BaseHumanOrgan -> OrganArachnidLiver ;
OrganAnimalLiver -> OrganArachnidLiver ;
BaseArachnidOrgan -> OrganArachnidLiver ;
BaseHumanOrgan -> OrganArachnidKidneys ;
OrganAnimalKidneys -> OrganArachnidKidneys ;
BaseArachnidOrgan -> OrganArachnidKidneys ;
BaseOrganEyes -> OrganArachnidEyes ;
BaseArachnidOrgan -> OrganArachnidEyes ;
BaseOrganTongue -> OrganArachnidTongue ;
BaseArachnidOrgan -> OrganArachnidTongue ;
BaseItem -> BaseBaseOrgan ;
BaseBaseOrgan -> BaseOrgan ;
BaseBaseOrgan -> BaseOrganBrain ;
BaseOrgan -> BaseOrganEyes ;
BaseOrgan -> BaseOrganTongue ;
BaseOrgan -> BaseOrganAppendix ;
BaseOrgan -> BaseOrganEars ;
BaseOrgan -> BaseOrganLungs ;
BaseOrgan -> BaseOrganHeart ;
BaseOrgan -> BaseOrganStomach ;
BaseOrgan -> BaseOrganLiver ;
BaseOrgan -> BaseOrganKidneys ;
BaseOrganLungs -> OrganAnimalLungs ;
BaseAnimalOrgan -> OrganAnimalLungs ;
BaseOrganStomach -> OrganAnimalStomach ;
BaseAnimalOrgan -> OrganAnimalStomach ;
BaseOrganLiver -> OrganAnimalLiver ;
BaseAnimalOrgan -> OrganAnimalLiver ;
BaseOrganHeart -> OrganAnimalHeart ;
BaseAnimalOrgan -> OrganAnimalHeart ;
BaseOrganKidneys -> OrganAnimalKidneys ;
BaseAnimalOrgan -> OrganAnimalKidneys ;
BaseOrganBrain -> OrganDionaBrain ;
BaseDionaOrgan -> OrganDionaBrain ;
BaseOrganEyes -> OrganDionaEyes ;
BaseDionaOrgan -> OrganDionaEyes ;
BaseOrganStomach -> OrganDionaStomach ;
BaseDionaOrgan -> OrganDionaStomach ;
BaseOrganLungs -> OrganDionaLungs ;
BaseDionaOrgan -> OrganDionaLungs ;
OrganDionaBrain -> OrganDionaBrainNymph ;
OrganDionaStomach -> OrganDionaStomachNymph ;
OrganDionaLungs -> OrganDionaLungsNymph ;
MobDionaNymph -> OrganDionaNymphBrain ;
MobDionaNymphAccent -> OrganDionaNymphStomach ;
MobDionaNymphAccent -> OrganDionaNymphLungs ;
OrganHumanHeart -> OrganDwarfHeart ;
OrganHumanLiver -> OrganDwarfLiver ;
OrganHumanStomach -> OrganDwarfStomach ;
BaseOrganBrain -> OrganHumanBrain ;
BaseHumanOrgan -> OrganHumanBrain ;
BaseOrganEyes -> OrganHumanEyes ;
BaseHumanOrgan -> OrganHumanEyes ;
BaseOrganTongue -> OrganHumanTongue ;
BaseHumanOrgan -> OrganHumanTongue ;
BaseOrganAppendix -> OrganHumanAppendix ;
BaseHumanOrgan -> OrganHumanAppendix ;
BaseOrganEars -> OrganHumanEars ;
BaseHumanOrgan -> OrganHumanEars ;
BaseOrganLungs -> OrganHumanLungs ;
BaseHumanOrgan -> OrganHumanLungs ;
BaseOrganHeart -> OrganHumanHeart ;
BaseHumanOrgan -> OrganHumanHeart ;
BaseOrganStomach -> OrganHumanStomach ;
BaseHumanOrgan -> OrganHumanStomach ;
BaseOrganLiver -> OrganHumanLiver ;
BaseHumanOrgan -> OrganHumanLiver ;
BaseOrganKidneys -> OrganHumanKidneys ;
BaseHumanOrgan -> OrganHumanKidneys ;
BaseOrganStomach -> OrganMothStomach ;
OrganAnimalLungs -> OrganRatLungs ;
OrganAnimalStomach -> OrganRatStomach ;
OrganAnimalStomach -> OrganReptilianStomach ;
BaseSlimeOrgan -> SentientSlimeCore ;
BaseOrganStomach -> SentientSlimeCore ;
BaseOrganBrain -> SentientSlimeCore ;
BaseSlimeOrgan -> OrganSlimeLungs ;
BaseOrganLungs -> OrganSlimeLungs ;
OrganHumanLungs -> OrganVoxLungs ;
}

out

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. No C# For things that don't need code. labels Sep 19, 2024
@0x6273
Copy link
Contributor

0x6273 commented Sep 19, 2024

Test fail looks real

@lzk228
Copy link
Contributor Author

lzk228 commented Sep 19, 2024

test gods got angry at me

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Sep 20, 2024

I gotta say, 5 layers of parenting hell seems like we're doing something wrong and should reevaluate whether we would rather just use more txt but not have this many reference abstractions.

@lzk228
Copy link
Contributor Author

lzk228 commented Sep 20, 2024

fixed tests and update pr info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants