Wires ui tooltip localization #32284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJB3005
requested changes
Sep 18, 2024
Content.Client/Wires/UI/WiresMenu.cs
Outdated
| "messing with wires will probably do stuff to them.\n" + | ||
| "Wire layouts are different each round, " + | ||
| "but consistent between machines of the same type."; | ||
| private readonly string _text = Loc.GetString("wires-menu-help-popup"); |
There was a problem hiding this comment.
No need to make this an instance variable, just resolve it in the function that uses it.
github-actions
bot
added
the
Status: Needs Review
PJB3005
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Wires ui tooltip localization
Resolves #31358
Why / Balance
Technical details
Media
Requirements
Breaking changes
Changelog
🆑 to4no_fix