Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutation effects that apply to plant should apply when planted #32258

Closed

Conversation

drakewill-CRL
Copy link
Contributor

About the PR

Effect mutations that apply to a plant (glow, etc) are now applied when planted.

Why / Balance

When you make a clipping from a plant with an effect, you expect that effect to be immediately visible.

Technical details

Checks for and apply any relevant effects when the seed is planted.

Media

fix, no image

Requirements

Breaking changes

Changelog

🆑

  • fix: Clipping from glowing plants will now glow immediately when planted.

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 17, 2024
@slarticodefast
Copy link
Member

How does it work at the moment? Is it waiting a few seconds for the plantholder to update?

@drakewill-CRL
Copy link
Contributor Author

The plant holder does not check the seed's mutation list for visual updates. This is different from the other values. This PR is a quick fix to get behavior closer to the original. The current behavior puts the mutation on the seed but doesn't apply them when planting, so produce will glow when harvested, but the plant(holder) itself doesn't change if you use a clipping that has a mutation on it.

@drakewill-CRL
Copy link
Contributor Author

Closing, since this will also be resolved with #31941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants