Tag Override for Equipment Slot Clothing Dependency #32140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the Harmony rules over.
Just mergin ol' upstream
Nother commit from upstream. 6/8/2024
More Upsteam mergy time
Big upstream merge
Fixed some bad spacing
Added missing attributes
Removed the scheduled portion of the publish workflow
Fixed a dumb spacing issue
Merging 6/22/24 from upstream
20240630 merge
pins loadout
Fourth of July upstream merge
7/6/2024 upstream merge
Attempting some proper workflow for CDN and Manifest update stuff.
Added a missing :
Changed from key to password for the SCP. Not great for security. But, for testing we'll stick with it.
Upstream20240907
Signed-off-by: TheCrimsonJupiter <[email protected]>
Signed-off-by: TheCrimsonJupiter <[email protected]>
Upstream20240909
…ntag-weights Midround antag weights
Re-added Crimson's Changes Signed-off-by: Kelderan <[email protected]>
…ject into an inventory slot.
github-actions
bot
added
Status: Needs Review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
RSI Diff Bot; head commit 4b8150e merging into 9b16822 Resources/Textures/Harmony/Clothing/Neck/Misc/serverpins.rsi
Resources/Textures/Harmony/Clothing/Neck/Misc/vulturepin.rsi
|
|
Closing this PR because I fucked up big time and opened from the wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added a new entity tag and logic for overriding the clothing requirement of inventory slots for specific objects.
Why / Balance
While I understand the need for balance in preventing gas tanks, guns, etc. from being able to be equipped in the suit storage without proper gear, some objects don't really make much sense to not be able to be worn, such as guitars. Some of these objects can be worn in the back slot, but it can be unnecessarily prohibitive to give up a backpack for them. This change allows for objects to have or be given a tag so that they can be equipped in their respective inventory slots without the need for the dependent clothing.
Technical details
~ tags.yml
∟ + New tag "SlotDependencyOverride" which can be added to equipable entities.
~ Content/Shared/Inventory/InventorySystem.Equip.cs
∟ + Added dependency and reference to the tagging system
∟ + Added small amount of logic under CanEquip() to handle skipping slot dependency check if the item contains the override tag
Media
This is only for example! No objects have had the tag added in this PR.
slot_dependency_override_ex.mp4
Requirements
Breaking changes
Changelog
No direct gameplay changes in this PR, only the setup for future changes.