Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentient medibot now can inject #32110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

godisdeadLOL
Copy link
Contributor

@godisdeadLOL godisdeadLOL commented Sep 12, 2024

About the PR

title

Why / Balance

Resolves #32023

Technical details

Media

medibot.mp4

Requirements

Breaking changes

Moved NPCRecentlyInjectedComponent to shared

Changelog

🆑 yuitop

  • tweak: sentient medibot can now inject

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 12, 2024
@a-person5660
Copy link

does this inject the correct chem based on the medi bots AI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been told that moving this to shared would be a breaking change. Probably should mention that in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Sadopeer
Copy link

Does it work when emaged, does it inject the right chem?

@godisdeadLOL
Copy link
Contributor Author

Yes, it injects the right chem even when emaged. I moved old injection code to MedibotSystem and use it for both ai and player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentient Medibot Cannot Inject
4 participants