Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New reptile sounds #32064

Merged
merged 20 commits into from
Oct 16, 2024
Merged

Conversation

Minemoder5000
Copy link
Contributor

@Minemoder5000 Minemoder5000 commented Sep 11, 2024

About the PR

Reptilians and Kobolds can now thump their tail.

Why / Balance

Additional sounds for roleplay purposes. Tail thump also included in SS13 Shiptest

Technical details

Added new type ReptilianBodyEmotes to speech_emote_sounds.yml
Added audio paths in speech_emote_sounds.yml
Added relevant emotes to emotes.ftl
Gave allowedEmotes component to Reptilians and Kobolds
Added new Emote icons

Media

reptile.tail.thump.mp4

Requirements

Breaking changes

Changelog

🆑 Minemoder, ArtisticRoomba, Sarahon

  • add: Reptiles and Kobolds can now thump their tail.

@github-actions github-actions bot added the No C# For things that don't need code. label Sep 11, 2024
@ArtisticRoomba
Copy link
Contributor

Here's what the sounds sound like.

MedalTVScreenRecording20240911024151-1726047806.2.mp4

BuildChecker/BuildChecker.csproj Outdated Show resolved Hide resolved
@VasilisThePikachu
Copy link
Member

undraft when you are ready!

@Minemoder5000 Minemoder5000 marked this pull request as ready for review September 12, 2024 04:55
@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 12, 2024
@UbaserB UbaserB added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Sep 12, 2024
Copy link
Member

@UbaserB UbaserB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the huff and hiss less guttural and more high pitched sorta (to match the other lizard emotes)?

@UbaserB UbaserB added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Sep 14, 2024
@Minemoder5000
Copy link
Contributor Author

Sure, I'll see if I can edit the current huff or find a different one that fits better

@foob1
Copy link

foob1 commented Sep 17, 2024

I suggest you read through #29448 since there was a lot of feedback on lizard noises there. I'd also like to add my own comments here but I already discussed it in the PR I linked

@UbaserB
Copy link
Member

UbaserB commented Sep 22, 2024

Sure, I'll see if I can edit the current huff or find a different one that fits better

Any progress on that?

@Minemoder5000
Copy link
Contributor Author

No, not really. I've been struggling to find some sounds that work and fit with current reptilian sounds. What parts of the hiss and huff were too guttural? I think I have a good idea of why the huff won't fit but I just want a bit more info that I can work with to find or make some good sounds.

@UbaserB
Copy link
Member

UbaserB commented Sep 22, 2024

No, not really. I've been struggling to find some sounds that work and fit with current reptilian sounds. What parts of the hiss and huff were too guttural? I think I have a good idea of why the huff won't fit but I just want a bit more info that I can work with to find or make some good sounds.

It's like, too low pitched with deep vibrations if you sorta get what i mean.

@Minemoder5000
Copy link
Contributor Author

Does that also apply to the hiss? Because the only low pitched rumbly part at the start of the sound isn't really that low pitched. I could trim that part of the hiss if it'd make the sound work.

@Minemoder5000
Copy link
Contributor Author

Alright so instead of letting this sit here forever, I've decided to just trim this PR down to the tail thump and not add the huff or hiss. How should I go about doing that? Should I remove the yaml changes, or comment them out so someone in the future can take it over? Should I remove or keep the huff and hiss emote icons for future use?

@UbaserB
Copy link
Member

UbaserB commented Oct 12, 2024

It'd be accepted then yeah i think

@UbaserB UbaserB added PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 13, 2024
@slarticodefast slarticodefast added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Oct 13, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 14, 2024
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tailslap.png image is missing a licence and attribution in Resources/Textures/Interface/Emotes/attributions.yml
Otherwise this is good to merge.

@slarticodefast slarticodefast self-assigned this Oct 16, 2024
@Minemoder5000
Copy link
Contributor Author

what the test fail doin

@slarticodefast
Copy link
Member

Random, unrelated test fail.
Code looks good to me. Thank you for your contribution!

@slarticodefast slarticodefast merged commit 17319c7 into space-wizards:master Oct 16, 2024
11 checks passed
@Minemoder5000 Minemoder5000 deleted the reptile-sounds branch October 16, 2024 10:08
@slarticodefast slarticodefast mentioned this pull request Oct 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. Status: Needs Review This PR requires new reviews before it can be merged. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants