-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New reptile sounds #32064
New reptile sounds #32064
Conversation
…ce-station-14 into reptile-sounds
…ce-station-14 into reptile-sounds
Here's what the sounds sound like. MedalTVScreenRecording20240911024151-1726047806.2.mp4 |
undraft when you are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the huff and hiss less guttural and more high pitched sorta (to match the other lizard emotes)?
Sure, I'll see if I can edit the current huff or find a different one that fits better |
I suggest you read through #29448 since there was a lot of feedback on lizard noises there. I'd also like to add my own comments here but I already discussed it in the PR I linked |
Any progress on that? |
No, not really. I've been struggling to find some sounds that work and fit with current reptilian sounds. What parts of the hiss and huff were too guttural? I think I have a good idea of why the huff won't fit but I just want a bit more info that I can work with to find or make some good sounds. |
It's like, too low pitched with deep vibrations if you sorta get what i mean. |
Does that also apply to the hiss? Because the only low pitched rumbly part at the start of the sound isn't really that low pitched. I could trim that part of the hiss if it'd make the sound work. |
Alright so instead of letting this sit here forever, I've decided to just trim this PR down to the tail thump and not add the huff or hiss. How should I go about doing that? Should I remove the yaml changes, or comment them out so someone in the future can take it over? Should I remove or keep the huff and hiss emote icons for future use? |
It'd be accepted then yeah i think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tailslap.png image is missing a licence and attribution in Resources/Textures/Interface/Emotes/attributions.yml
Otherwise this is good to merge.
what the test fail doin |
Random, unrelated test fail. |
About the PR
Reptilians and Kobolds can now thump their tail.
Why / Balance
Additional sounds for roleplay purposes. Tail thump also included in SS13 Shiptest
Technical details
Added new type ReptilianBodyEmotes to speech_emote_sounds.yml
Added audio paths in speech_emote_sounds.yml
Added relevant emotes to emotes.ftl
Gave allowedEmotes component to Reptilians and Kobolds
Added new Emote icons
Media
reptile.tail.thump.mp4
Requirements
Breaking changes
Changelog
🆑 Minemoder, ArtisticRoomba, Sarahon