fix #31963: Stopped climbing movent while in containers

[benev0]

About the PR

This resolves a bug that allows players to shoot while inside crates/lockers

Why / Balance

resolves #31963

Technical details

Block final transform for climbing while entity (player) is in a container.
Final climb may succeed still while in container, but the player remains in place.

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• fix: Stopped climbing movent while in containers

[lzk228]

thank you very much, also i suggest you to read this

[benev0]

thanks, I was unaware that could be done automatically

[benev0]

After interacting with this problem it appears that there is a problem with the methods registered to events, and will require further attention.

It appears that event registers to stop the doAfter for Buckling and Storing

[benev0]

issues from #31963 should be correctly addressed: awaiting further review

• entities which are in storage cannot initiate climbing
• entities which enter storage have climb DoAfters canceled
• entities which become buckled have climb DoAfters canceled
  • unresolved issued likely fixed with Unbuckle doesn't get predicted correctly #31813 resolution
  • DoAfters slow to cancel after buckle

[metalgearsloth]

This should be done up the callstack in canclimb or the likes not after climbing is happening.

[benev0]

The ClimbingComponent field CanClimb is effectively unused as it is never altered from a true state. The code alteration could be made by subscribing to container remove as well, but if CanClimb is to be used I would recommend scoping this up from a bug fix to a ClimbSystem Rework.

I have moved the inventory check into OnDoAfter where it will stop the call of climb. I have also observed that it is technicality unnecessary but will result in visible rollback if not checked before climbing is initiated.

[benev0]

glorious, test failed; I shall look into it.