Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cham projector fixes/rewrite #27111

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Apr 19, 2024

About the PR

Why / Balance

🐛 🔨

disguising as something in your pocket is cringe like !pch on prop hunt, randomly turn into something that cant be there

Technical details

  • an aghost using projector no longer throws
  • instead of polymorph, it makes your player invisible and spawns a disguise parented to it.
    being invisible disables verb menu and click attacks but shooting wide swing spacing radiation etc still damage you
  • damage revealing is now just based on taking X damage while disguised, instead of a polymorph entity going crit

Media

popup when trying to disguise as something in your pocket/bag/whatever
01:00:51

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no longer uses polymorph, the disguise entity is now just for visuals

Changelog
no cl no fun

@deltanedas deltanedas changed the title cham projector fixes cham projector fixes/rewrite Apr 19, 2024
@deltanedas
Copy link
Contributor Author

merg

@deltanedas
Copy link
Contributor Author

mmmmmmmmmmmmmmmmmmmmerg

@deltanedas
Copy link
Contributor Author

@mirrorcult merg

Copy link
Contributor

github-actions bot commented Jun 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jun 2, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Jun 3, 2024
@deltanedas
Copy link
Contributor Author

someone merg this has been running on deltav for ages no issues :trollface: seal of approval

Copy link
Contributor

@AJCM-git AJCM-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aggressively ping me if by next week i haven't come around to this one (in the meantime, do access to the components + l + ratio) (also test with multiple clients and going inside/outside pvs range with em if you havent already) (just saw the deltav testing so you are (prob) guzzy)

@AJCM-git AJCM-git added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Jun 14, 2024
@deltanedas deltanedas requested a review from AJCM-git June 14, 2024 02:50
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Jun 14, 2024
Copy link
Contributor

@AJCM-git AJCM-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces other issues like that the chameleon items dont have interaction outlines and you cant melee them or pick them up, which makes them very easy to spot, also were they always this prone to crashes in debug? i cant fiddle with them for like 5 seconds without getting a client or server crash which is pretty sus.
The general approach is a little odd? It would be better to improve polymorphing to fix the issues it had, tho if you find a way to fix the new issues that isnt jank thats fine too

@AJCM-git AJCM-git added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Jun 15, 2024
deltanedas added 2 commits June 15, 2024 21:24
@deltanedas deltanedas requested a review from AJCM-git June 16, 2024 08:13
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Jun 16, 2024
@AJCM-git AJCM-git added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Jun 16, 2024
@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 11, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 11, 2024
@deltanedas
Copy link
Contributor Author

@AJCM-git merg

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Jul 25, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 8, 2024
@Emisse
Copy link
Contributor

Emisse commented Aug 18, 2024

is this real

@deltanedas
Copy link
Contributor Author

yes

@deltanedas
Copy link
Contributor Author

someone merge already its been like 6 months

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
3 participants