fix: EntityPrototypeView now only creates entity when in opened ui (after EnteredTree and not after ExitedTree) #5491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter EnteredTree and not after ExitedTree)
|
Tested new version of code with lathe. But I don't know where to test call to SetPrototype when window is already opened - thats some kind of update on-the-run... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for EntityPrototypeView creating entities on setting ProtoId. This was the problem that caused space-wizards/space-station-14#32339 to fail tests - "crafting recepie ui" is connected to controller that is updating on server init with fresh list of recepies. And this update initializes UI even without opening it - which leads to creation of entities without actually deleting them (not in master, but in this menu translation PR).
Fixed following this discussion.