Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntityCoordinates and MapCoordinates consistency #5389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

EntityCoordinates and MapCoordinates consistency #5389

wants to merge 1 commit into from

Conversation

Winkarst-cpu
Copy link
Contributor

Resolves #2853 (will just need to change everything to get rid of warnings).

  • 180 new warnings in RobustToolbox.
  • 110 new warnings in SS14.

@PJB3005
Copy link
Member

PJB3005 commented Aug 27, 2024

project zero warnings in shambles

@Winkarst-cpu
Copy link
Contributor Author

project zero warnings in shambles

Exactly :trollface:

PJB3005
PJB3005 requested changes Sep 1, 2024
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah no I'm just hard-blocking this PR until we get warnings under control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 requested changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EntityCoordinates and MapCoordinates args are inverse
2 participants
@Winkarst-cpu @PJB3005