Misc Toolshed tweaks #4990
Merged
Misc Toolshed tweaks #4990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into toolshed-tweaks
moonheart08
suggested changes
Mar 23, 2024
Co-authored-by: Moony <[email protected]>
ElectroJr
commented
Mar 23, 2024
|
|
||
| if (parameters.TryGetValue(subCmd ?? "", out var existing)) | ||
| { | ||
| if (!existing.SequenceEqual(existing)) |
There was a problem hiding this comment.
This was previously bugged because existing.SequenceEqual(existing) is always true. After I fixed it, many commands started erroring so I though the feature was implemented, but I misunderstood it.
If I understand correctly now, it works as long as the (sub)command name & piped type are unique, so I changed the parameters dictionary key to a (string, Type?) tuple
moonheart08
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICommonSessionparserCommandDiscriminatorequality override not actually overriding the default record struct equality. This was causing it to constantly add new entries to the_concreteImplementationsdictionary.Removes an obsolete & broken not-implemented exceptionactually it appears to still be requiredILocalizationManagerto parsers & commands.