Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio filepath completion helper #4968

Merged

Conversation

metalgearsloth
Copy link
Contributor

Due to how audio is packaged server doesn't have most audio files.

Due to how audio is packaged server doesn't have most audio files.
@PJB3005
Copy link
Member

PJB3005 commented Mar 17, 2024

image
does this actually work now? I checked out the PR and this happens.

@metalgearsloth
Copy link
Contributor Author

does this actually work now? I checked out the PR and this happens.

Dahell, let me check again coz it was autocompleting both for me.

@PJB3005
Copy link
Member

PJB3005 commented Mar 18, 2024

I am an idiot that might have forgotten to test the content PR

@metalgearsloth metalgearsloth merged commit 8d47771 into space-wizards:master Mar 24, 2024
4 checks passed
@metalgearsloth metalgearsloth deleted the 2024-03-16-audio-completion branch March 24, 2024 03:12
DEATHB4DEFEAT added a commit to Simple-Station/Einstein-Engines that referenced this pull request Jul 12, 2024
## Mirror of PR #26167: [Fix playglobalsound
autocompletion](space-wizards/space-station-14#26167)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `65960facf522627c939a35a65b025ec49ffa5c52`

PR opened by <img
src="https://avatars.githubusercontent.com/u/31366439?v=4"
width="16"/><a href="https://github.com/metalgearsloth">
metalgearsloth</a> at 2024-03-16 03:02:08 UTC

---

PR changed 1 files with 3 additions and 1 deletions.

The PR had the following labels:
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> Requires space-wizards/RobustToolbox#4968


</details>

Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants